Optimize the batch deserialization perf #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschork
reviewed
May 21, 2024
node/grpc/utils.go
Outdated
| "github.com/wealdtech/go-merkletree" | ||
| "github.com/wealdtech/go-merkletree/keccak256" | ||
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| var ( | ||
| maxDeserializationWorkers = 32 |
There was a problem hiding this comment.
would be nice to expose this in operator config for tuning purposes
There was a problem hiding this comment.
sounds good, I didn't make it so as I was thinking the validator was not using flag yet and wanted to do it together separately later (validation is actually using flag)
dmanc
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The batch request deserialization is CPU intensive (especially at scale), however it's parallelizable.
This makes it about 5x faster in preprod test.
Checks