Add nonsigning rate threshold control to ejector #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
reviewed
Jun 6, 2024
| @@ -146,6 +146,13 @@ var ( | |||
| Value: 6 * time.Minute, | |||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "TRANSACTION_TIMEOUT"), | |||
| } | |||
| NonsigningRateThresholdFlag = cli.IntFlag{ | |||
| Name: common.PrefixFlag(FlagPrefix, "nonsigning-rate-threshold"), | |||
| Usage: "only operators with nonsigning rate >= this threshold are eligible for ejection, this value must be in range [10, 100], any value not in this range means disabling this flag", | |||
There was a problem hiding this comment.
disabling the flag means, eject based on regular SLA?
There was a problem hiding this comment.
Yes, no additional conditions to affect the standard SLA and ejection flow.
| @@ -82,6 +84,11 @@ func (e *Ejector) Eject(ctx context.Context, nonsigningRate *OperatorsNonsigning | |||
|
|
|||
| nonsigners := make([]*OperatorNonsigningPercentageMetrics, 0) | |||
| for _, metric := range nonsigningRate.Data { | |||
| // If nonsigningRateThreshold is set and valid, we will only eject operators with | |||
| // nonsigning rate >= nonsigningRateThreshold. | |||
| if e.nonsigningRateThreshold >= 10 && e.nonsigningRateThreshold <= 100 && metric.Percentage < float64(e.nonsigningRateThreshold) { | |||
There was a problem hiding this comment.
what if e.nonsigningRateThreshold is 9, then regular SLA is enforced.
then if e.nonsigningRateThreshold is 50, then we enable the relaxed ejection.
There was a problem hiding this comment.
In first case: e.nonsigningRateThreshold will have no effect, it will just perform regular ejection
In second case: it'll eject an operator if 1) the operator violates SLA; AND 2) the operator's nonsigning rate >= 50%
Note: when it's regular ejection, only condition 1) is used
jianoaix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Allow gradual rollout of ejection.
Tested: locally
Checks