Adds support for multi-platform linux/amd64 & linux/arm64 docker images #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschork
force-pushed
the
pschork/multi-platform-releases
branch
from
fd5e7d5 to
03eea53
Compare
dmanc
approved these changes
Jun 14, 2024
docker-compose-internal.yaml
Outdated
| @@ -24,6 +24,9 @@ services: | |||
| build: | |||
| context: . | |||
| dockerfile: node/cmd/Dockerfile | |||
| platforms: | |||
| - "linux/amd64" | |||
| - "linux/arm64" | |||
There was a problem hiding this comment.
Should we add arm images to the other components too?
There was a problem hiding this comment.
Dropping this from this change. Building with docker compose is kludgy and we might be better off using buildx directly. This is also triggering a failure with gitversion that needs more debugging.
This reverts commit 8c82532.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow operators to run released docker images on ARM based AWS Gravitron instances as well as M1/2/3 Macs
Multi-platform docker compose builds need to be built + pushed within the same context, so this change consolidates the previous 2-staged built + push flow into a single build + potentially push flow via a
PUSH_FLAGenv variable that gets set if a push is intended.Why are these changes needed?
Checks