Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitVersion regex to properly identify versioned tags when building in detached HEAD mode #605

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Jun 14, 2024

Previously if you created a tag v0.7.4-pre.1 it would resolve semver as 0.7.4-tags-v0-7-4-pre-1.1 as opposed to 0.7.4-pre.1

I discovered this when I tagged a pre-release multi-platform build v0.7.4-pre.1

Official releases are not impacted because they live in a release branch using release/X.Y.Z format and gitversion is able to identify the correct semver.

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Sorry, something went wrong.

…d HEAD mode

Previously if you created a tag `v0.7.4-pre.1` it would resolve semver as `0.7.4-tags-v0-7-4-pre-1.1`
@pschork pschork requested a review from dmanc June 14, 2024 23:08
@dmanc
Copy link
Contributor

dmanc commented Jun 14, 2024

Some unit tests failing but doesn't look related

@pschork pschork merged commit eb54a4e into master Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants