Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate quorum ID #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate quorum ID #610

wants to merge 1 commit into from

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Adding some missing validations on quorum ID range

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review June 20, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph Awaiting requested review from mooselumph

@jianoaix jianoaix Awaiting requested review from jianoaix

@anupsv anupsv Awaiting requested review from anupsv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ian-shim