Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record args in mock transactor #616

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Record the arguments in mock transactor so arguments can be asserted

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from dmanc and jianoaix June 24, 2024 22:01
@ian-shim ian-shim marked this pull request as ready for review June 24, 2024 22:01
@ian-shim ian-shim force-pushed the record-args-in-mock-tx branch from 0d4e6b1 to 7f2c897 Compare June 24, 2024 22:14
@ian-shim ian-shim merged commit 4223770 into Layr-Labs:master Jun 24, 2024
6 checks passed
pschork pushed a commit that referenced this pull request Jun 26, 2024
pschork pushed a commit that referenced this pull request Jun 26, 2024
pschork pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants