Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minibatch] Create minibatch from encoding streamer #637

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Tweaks existing CreateBatch method that returns a minibatch.
CreateMinibatch method is equivalent to CreateBatch except:

  • it removes the encoded blobs immediately once retrieved to make a batch
  • it does not reset the reference block number

It also adds a UpdateReferenceBlock method that batch confirmer can call to reset the reference block number.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from pschork and mooselumph July 12, 2024 23:01
@ian-shim ian-shim marked this pull request as ready for review July 12, 2024 23:18
@ian-shim ian-shim requested a review from bxue-l2 July 12, 2024 23:18
@ian-shim ian-shim merged commit 52d60a7 into Layr-Labs:master Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants