Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Node Info during reachability check if port scan was successful #640

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Jul 16, 2024

Allows us to track node versions when nodes request reachability checks

We only attempt a NodeInfo request if the dispersal socket was validated as open.

Log from node with NodeInfo resource collection (default behavior)

{"msg":"NodeInfo","component":"DataAPIServer","operatorId":"a96bfb4a7ca981ad365220f336dc5a3de0816ebd5130b79bbc85aca94bc9b6ab","semver":"0.7.5-pre.1","os":"linux","arch":"amd64","numCpu":8,"memBytes":33545670656}

Log from node with NODE_ENABLE_NODE_INFO_RESOURCES=false will only populate semver

{"msg":"NodeInfo","component":"DataAPIServer","operatorId":"a96bfb4a7ca981ad365220f336dc5a3de0816ebd5130b79bbc85aca94bc9b6ab","semver":"0.7.5pre.1","os":"","arch":"","numCpu":0,"memBytes":0}  

Legacy operator nodes will be tracked with semver: unknown

{"msg":"NodeInfo","component":"DataAPIServer","operatorId":"a96bfb4a7ca981ad365220f336dc5a3de0816ebd5130b79bbc85aca94bc9b6ab","semver":"unknown"}                                                                                                                                                                                                       

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork force-pushed the pschork/host_info_metrics branch 2 times, most recently from 75ac9d3 to fd021ae Compare July 16, 2024 21:39
@pschork pschork force-pushed the pschork/host_info_metrics branch from fd021ae to d9c30d2 Compare July 16, 2024 22:21
@pschork pschork requested a review from ian-shim July 16, 2024 22:25
@pschork pschork marked this pull request as ready for review July 16, 2024 22:25
@pschork pschork changed the title Call node info endpoint on dispersal socket if port scan was successful Collect Node Info during reachability check if port scan was successful Jul 16, 2024
@pschork pschork merged commit 4590592 into master Jul 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants