Inabox readme improvements #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
pschork
reviewed
Jul 17, 2024
inabox/README.md
Outdated
| @@ -155,6 +175,13 @@ TRACE[10-12|22:02:13.376] [batcher] AggregateSignatures took duration=10.6 | |||
| TRACE[10-12|22:02:13.376] [batcher] Confirming batch... caller=batcher.go:198 | |||
| ``` | |||
|
|
|||
| To dispense that same blob (replace `$REQUEST_ID` with the request ID from the prior step): | |||
There was a problem hiding this comment.
To check the status of that same blob
There was a problem hiding this comment.
Change made.
Suggested change
| To dispense that same blob (replace `$REQUEST_ID` with the request ID from the prior step): | |
| To check the status of that same blob (replace `$REQUEST_ID` with the request ID from the prior step): |
jianoaix
approved these changes
Jul 17, 2024
Signed-off-by: Cody Littley <[email protected]>
ian-shim
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The tutorial in
inabox/README.mdwas incomplete. This PR adds the missing steps.Checks