Generate inclusion proof with blob index instead of hash #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
fix-inclusion-proof
branch
from
7b9375d to
10b5851
Compare
bxue-l2
approved these changes
Jul 19, 2024
jianoaix
reviewed
Jul 19, 2024
| continue | ||
| } | ||
| merkleProof, err := batchData.merkleTree.GenerateProof(blobHeaderHash[:], 0) | ||
| merkleProof, err := batchData.merkleTree.GenerateProofWithIndex(uint64(blobIndex), 0) |
There was a problem hiding this comment.
Any compatibility issue with this change?
There was a problem hiding this comment.
Shouldn't be. It won't affect blobs that had been dispersed already. It will only affect blobs to be dispersed after the deploy by populating correct inclusion proofs in the confirmation info
There was a problem hiding this comment.
What about the consumer of this inclusion proof? Will this break anything on that side?
There was a problem hiding this comment.
No the consumer of the inclusion proof reads it from DB without re-generating it
jianoaix
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously, it was using the blob header hash to identify the index of the leaf, which is problematic when there are duplicate leaves.
Generating proofs with the leaf index solves this issue.
Checks