Minibatch dynamodb client #652
Merged
+1,036
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
reviewed
Jul 23, 2024
pschork
force-pushed
the
pschork/minibatch_client
branch
2 times, most recently
from
cf40593 to
45f9a09
Compare
ian-shim
reviewed
Jul 25, 2024
ian-shim
approved these changes
Jul 25, 2024
| KeyType: types.KeyTypeHash, | ||
| }, | ||
| { | ||
| AttributeName: aws.String("CreatedAt"), |
There was a problem hiding this comment.
Would this index records that don't have CreatedAt attribute?
There was a problem hiding this comment.
No. All items indexed by a GSI must have values for the attributes that are part of the GSI's key schema. If we had used CreatedAt (as opposed to RequestedAt) for DispersalRequest, DispersalRequests still would not have been included in the GSI because DispersalRequest does not define BatchStatus
pls do. I just approved |
Replace DispersalRequest.OperatorID field with raw byte array def so that dynamo can use unmarshalMap
Convert PK to BatchID Adds custom minibatch struct conversion for batch, minibatch, dispersalRequest, dispersalResponse
Add remaining minibatch store functions
Remove blobMetadataIndex
Add unique constraint on (batchID,BATCH#batchID)
pschork
force-pushed
the
pschork/minibatch_client
branch
from
b6deafb to
4551c2a
Compare
pschork
added a commit
that referenced
this pull request
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Minibatch dynamodb client
Schema uses single table design
Checks