Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eigenda_client.go to print waiting loop as debug logs instead of info logs #713

Closed
wants to merge 1 commit into from
Closed

chore: update eigenda_client.go to print waiting loop as debug logs instead of info logs #713

wants to merge 1 commit into from

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Aug 20, 2024

Why are these changes needed?

We use this in the eigenda-proxy. Seeing a lot of repeating logs which just clutter the output:
image

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@samlaf samlaf requested review from epociask and jianoaix August 20, 2024 04:59
@samlaf
Copy link
Contributor Author

samlaf commented Dec 16, 2024

Closing as this is super outdated and I'm too lazy to fix the conflict.

@samlaf samlaf closed this Dec 16, 2024
@samlaf samlaf deleted the samlaf-patch-1 branch December 16, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@epociask epociask Awaiting requested review from epociask

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlaf @jianoaix