[RedisCache] For RateLimiting #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2023 10:39
siddimore
requested review from
mooselumph,
jianoaix and
wmb-software-consulting
wmb-software-consulting
suggested changes
Nov 30, 2023
| client *commoncache.RedisClient | ||
| } | ||
|
|
||
| func NewRedisStore[T any](client *commoncache.RedisClient) common.KVStore[T] { |
There was a problem hiding this comment.
client Should be an interface and not implementation
| ) | ||
|
|
||
| type RedisStore[T any] struct { | ||
| client *commoncache.RedisClient |
There was a problem hiding this comment.
Should be an interface and not implementation
| return err | ||
| } | ||
|
|
||
| return s.client.Set(ctx, key, jsonData, 0).Err() // 0 means no expiration |
There was a problem hiding this comment.
What if we want do add expiration? What do you think of adding it as params?
| "time" | ||
|
|
||
| "github.com/Layr-Labs/eigenda/common" | ||
| "github.com/go-redis/redis/v8" |
There was a problem hiding this comment.
Why v8 and not v9
| client *commoncache.RedisClient | ||
| } | ||
|
|
||
| func NewRedisStore[T any](client *commoncache.RedisClient) common.KVStore[T] { |
There was a problem hiding this comment.
Preferable to return pointer struct instead of interface by convention
*RedisStore[T]
| type RedisStore[T any] struct { | ||
| client *commoncache.RedisClient | ||
| } | ||
|
|
There was a problem hiding this comment.
Add this interface static checker.
var _ common.KVStore[any] = (*RedisStore[any])(nil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Introduce RedisStore instead of dynamoDB for storing RateLimiting Params
Changes
Checks