V2 Blob Verification #781

0x0aa0 · 2024-10-02T20:21:14Z

V2
consolidates structs into common interface
moves V1 thresholds to ThresholdRegistry while maintaining DASM interface
renames RollupUtils to BlobVerificationUtils which implements V2 and batched util for V1
introduces chain abstract immutable BlobVerifier contract to interact with BlobVerificationUtils
adds relay registry

contracts/src/libraries/EigenDABlobVerificationUtils.sol

contracts/src/interfaces/IEigenDABlobVerifier.sol

contracts/src/core/EigenDAThresholdRegistry.sol

contracts/src/libraries/EigenDABlobVerificationUtils.sol

ian-shim

few questions

ian-shim · 2024-11-19T17:55:29Z

contracts/src/core/EigenDAThresholdRegistryStorage.sol

+
+    bytes public quorumConfirmationThresholdPercentages;
+
+    bytes public quorumNumbersRequired;


is this still necessary? I thought we were going to give flexibility to disperse to any quorums except charging the same amount for dispersing to 1 quorum vs. all required quorums

ya this is still needed for V1 verification

contracts/src/interfaces/IEigenDABlobVerifier.sol

ian-shim · 2024-11-19T17:58:26Z

contracts/src/core/EigenDAThresholdRegistryStorage.sol

+
+    mapping(uint16 => VersionedBlobParams) public versionedBlobParams;
+
+    SecurityThresholds public defaultSecurityThresholdsV2;


are we allowing the ability to provide custom security thresholds?

yes you can supply custom security thresholds in V2 verification

ian-shim · 2024-11-19T18:00:11Z

contracts/src/core/EigenDABlobVerifier.sol

+     * @param blobHeader The blob header to verify
+     * @param blobVerificationProof The blob verification proof to verify the blob against
+     */
+    function verifyBlobV1(


do existing v1 integrations need to update and call this new method or can they continue using the old verify method?

old library will continue to work

curious why we need V1 verifications - anyone calling these functions will do so directly through the Service Manager wrapper (i.e, Verifier contracts in Nitro). Don't see how this enables or helps cross compatibility between V1 <--> V2.

ian-shim · 2024-11-19T18:03:05Z

contracts/src/core/EigenDARelayRegistry.sol

+contract EigenDARelayRegistry is IEigenDARelayRegistry, OwnableUpgradeable {
+
+    mapping(uint32 => string) public relayIdToURL;
+    mapping(address => uint32) public relayAddressToId;


Curious what's a relay address?

onchain address of a relay, the thinking here is that in the future we may want this mapping to permission updates from relays

contracts/src/core/EigenDAThresholdRegistry.sol

contracts/src/interfaces/IEigenDAStructs.sol

contracts/src/core/EigenDABlobVerifier.sol

contracts/compile.sh

contracts/src/core/EigenDAThresholdRegistry.sol

ian-shim · 2024-12-03T22:49:36Z

contracts/src/core/EigenDARelayRegistry.sol

+        return nextRelayKey++;
+    }
+
+    function getRelayURL(uint32 key) external view returns (string memory) {


should it check if key < nextRelayKey?

ian-shim · 2024-12-03T22:50:07Z

contracts/src/core/EigenDAThresholdRegistry.sol

+
+    /// @notice Returns the blob params for a given blob version
+    function getBlobParams(uint16 version) external view returns (VersionedBlobParams memory) {
+        return versionedBlobParams[version];


same here, should we check version < nextBlobVersion?

dont think it is totally necessary to require on the getter

ian-shim · 2024-12-03T22:56:00Z

One thing to keep consistent is which uint types represent blob versions/relay keys. Offchain, we use uint8 for blob versions and uint16 for relay keys, but here we're using uint16 and uint32 respectively. Which types do we want? cc @mooselumph @cody-littley

ian-shim · 2024-12-04T04:48:37Z

contracts/script/EigenDADeployer.s.sol

@@ -226,6 +242,42 @@ contract EigenDADeployer is DeployOpenEigenLayer {
            )
        );

+        eigenDAThresholdRegistryImplementation = new EigenDAThresholdRegistry();
+
+        VersionedBlobParams[] memory versionedBlobParams = new VersionedBlobParams[](0);


Does it make sense to hardcode the params for version 0 here if we're going to use the same values across all environments?

contracts/src/libraries/EigenDAHasher.sol

gpsanant · 2024-12-05T06:52:38Z

contracts/src/core/EigenDARelayRegistry.sol

+        _disableInitializers();
+    }
+
+    function initialize(


addd natspec to interfaces and use @inheritdoc

contracts/src/core/EigenDARelayRegistry.sol

gpsanant · 2024-12-05T06:55:25Z

contracts/src/core/EigenDAServiceManager.sol

    }

    /// @notice Returns the bytes array of quorumAdversaryThresholdPercentages
    function quorumConfirmationThresholdPercentages() external view returns (bytes memory) {
-        return hex"373737";
+        return eigenDAThresholdRegistry.quorumConfirmationThresholdPercentages();
    }

    /// @notice Returns the bytes array of quorumsNumbersRequired
    function quorumNumbersRequired() external view returns (bytes memory) {


is this for backwards compatability or?

contracts/src/core/EigenDAThresholdRegistry.sol

gpsanant · 2024-12-05T06:59:16Z

contracts/src/core/EigenDAThresholdRegistry.sol

+    function getQuorumAdversaryThresholdPercentage(
+        uint8 quorumNumber
+    ) public view virtual returns (uint8 adversaryThresholdPercentage) {
+        if(quorumAdversaryThresholdPercentages.length > quorumNumber){


we should revert if no?

EthenNotEthan · 2024-12-02T21:26:38Z

contracts/src/core/EigenDABlobVerifier.sol

+        BatchHeaderV2 calldata batchHeader,
+        BlobVerificationProofV2 calldata blobVerificationProof,
+        NonSignerStakesAndSignature calldata nonSignerStakesAndSignature


on the rollup side we interpret this three element tuple as a certificate type. Is there any benefit to representing the EigenDA certificate type here?

we implicitly use this term across our documentation and integrations - would be nice to have an explicit definition

EthenNotEthan · 2024-12-05T20:03:59Z

contracts/src/core/EigenDABlobVerifier.sol

+import {IEigenDARelayRegistry} from "../interfaces/IEigenDARelayRegistry.sol";
+import "../interfaces/IEigenDAStructs.sol";
+
+contract EigenDABlobVerifier is IEigenDABlobVerifier {


In lieu of all the renamings going on - does it make sense to call this contract a BlobVerifier? It's not actually verifying the blob but instead a tuple of different commitments which attest that the blob has been successfully aggregated and dispersed. Verifying the blob makes me think of providing a kzg witness proof generated from the blob and verifying against the data commitment which this contract doesn't do.

CC @samlaf @bxue-l2

EthenNotEthan · 2024-12-05T20:05:05Z

contracts/src/core/EigenDABlobVerifier.sol

+     * @param blobHeader The blob header to verify
+     * @param blobVerificationProof The blob verification proof to verify the blob against
+     */
+    function verifyBlobV1(


curious why we need V1 verifications - anyone calling these functions will do so directly through the Service Manager wrapper (i.e, Verifier contracts in Nitro). Don't see how this enables or helps cross compatibility between V1 <--> V2.

ian-shim

One comment outside this PR but relevant, shouldn't the reference block number be removed from blob certificate?

ian-shim · 2024-12-12T02:24:06Z

contracts/src/interfaces/IEigenDAStructs.sol

@@ -65,7 +70,6 @@ struct BlobVerificationProofV2 {

 struct BlobCertificate {
    BlobHeaderV2 blobHeader;
-    uint32 referenceBlockNumber;


I think it should be removed from Attestation as well

0x0aa0 added 2 commits October 2, 2024 15:14

blob verification

f00c0f9

v2 interface

ea81dcf

ian-shim reviewed Oct 22, 2024

View reviewed changes

contracts/src/libraries/EigenDABlobVerificationUtils.sol Outdated Show resolved Hide resolved

contracts/src/interfaces/IEigenDABlobVerifier.sol Outdated Show resolved Hide resolved

ian-shim reviewed Oct 23, 2024

View reviewed changes

contracts/src/core/EigenDAThresholdRegistry.sol Show resolved Hide resolved

ian-shim reviewed Oct 23, 2024

View reviewed changes

contracts/src/libraries/EigenDABlobVerificationUtils.sol Outdated Show resolved Hide resolved

0x0aa0 added 6 commits November 18, 2024 14:26

consolidate structs

ada0dc3

blob versioning

47b4201

v2 verification

7f713f3

relay registry

aabe59e

Merge branch 'master' into quaq/blob-verification

9aafc47

fix conflicts

c259dae

0x0aa0 changed the title ~~blob verification refactor~~ V2 Blob Verification Nov 19, 2024

0x0aa0 marked this pull request as ready for review November 19, 2024 15:34

0x0aa0 requested review from ian-shim, mooselumph, cody-littley and gpsanant November 19, 2024 15:34

ian-shim reviewed Nov 19, 2024

View reviewed changes

nits

8136dee

0x0aa0 mentioned this pull request Nov 20, 2024

V2 interfaces #920

Merged

0x0aa0 and others added 6 commits November 20, 2024 16:18

Merge branch 'master' into quaq/blob-verification

31017e2

rm binding update

8937de0

V2 verification behavior

6cfd640

Merge branch 'master' into quaq/blob-verification

2420319

fix script

d9cf91e

Merge branch 'master' into quaq/blob-verification

f903bdf

samlaf reviewed Dec 2, 2024

View reviewed changes

contracts/src/core/EigenDABlobVerifier.sol Show resolved Hide resolved

samlaf reviewed Dec 2, 2024

View reviewed changes

contracts/src/core/EigenDABlobVerifier.sol Outdated Show resolved Hide resolved

0x0aa0 requested a review from EthenNotEthan December 2, 2024 20:32

ian-shim reviewed Dec 3, 2024

View reviewed changes

contracts/compile.sh Outdated Show resolved Hide resolved

0x0aa0 added 3 commits December 2, 2024 20:58

fix: NonSignerStakesAndSignature quorum numbers

09422bc

keep mock rollup as V1 example

c053a5d

relay registry update

895b131

ian-shim reviewed Dec 3, 2024

View reviewed changes

contracts/src/core/EigenDAThresholdRegistry.sol Outdated Show resolved Hide resolved

0x0aa0 added 3 commits December 3, 2024 15:03

v2 verify from signed batch

8c8069b

append only blob params

623b250

fix: blob param init

e81c96b

ian-shim reviewed Dec 3, 2024

View reviewed changes

ian-shim reviewed Dec 4, 2024

View reviewed changes

update blob header hashing

76b4395

ian-shim reviewed Dec 5, 2024

View reviewed changes

contracts/src/libraries/EigenDAHasher.sol Show resolved Hide resolved

gpsanant reviewed Dec 5, 2024

View reviewed changes

contracts/src/core/EigenDARelayRegistry.sol

_disableInitializers();

}

function initialize(

Copy link

gpsanant Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addd natspec to interfaces and use @inheritdoc

gpsanant reviewed Dec 5, 2024

View reviewed changes

contracts/src/core/EigenDARelayRegistry.sol Outdated Show resolved Hide resolved

gpsanant reviewed Dec 5, 2024

View reviewed changes

contracts/src/core/EigenDARelayRegistry.sol Outdated Show resolved Hide resolved

gpsanant reviewed Dec 5, 2024

View reviewed changes

contracts/src/core/EigenDAThresholdRegistry.sol Show resolved Hide resolved

gpsanant reviewed Dec 5, 2024

View reviewed changes

EthenNotEthan reviewed Dec 5, 2024

View reviewed changes

ian-shim reviewed Dec 9, 2024

View reviewed changes

0x0aa0 added 4 commits December 9, 2024 14:12

rm additional verification options

336f9e5

threshold registry events

39cfd64

update relay registry

8931b05

rm referenceBlockNumber from cert

dca5a2d

ian-shim approved these changes Dec 10, 2024

View reviewed changes

0x0aa0 merged commit 3ed9ef6 into master Dec 11, 2024
9 checks passed

ian-shim reviewed Dec 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V2 Blob Verification #781

V2 Blob Verification #781

0x0aa0 commented Oct 2, 2024 •

edited

Loading

ian-shim left a comment

ian-shim Nov 19, 2024

0x0aa0 Nov 19, 2024

ian-shim Nov 19, 2024

0x0aa0 Nov 19, 2024

ian-shim Nov 19, 2024

0x0aa0 Nov 19, 2024

EthenNotEthan Dec 5, 2024

ian-shim Nov 19, 2024

0x0aa0 Nov 19, 2024

ian-shim Dec 3, 2024

ian-shim Dec 3, 2024

0x0aa0 Dec 3, 2024

ian-shim commented Dec 3, 2024 •

edited

Loading

ian-shim Dec 4, 2024

gpsanant Dec 5, 2024

gpsanant Dec 5, 2024

0x0aa0 Dec 5, 2024

gpsanant Dec 5, 2024

EthenNotEthan Dec 2, 2024

EthenNotEthan Dec 5, 2024

EthenNotEthan Dec 5, 2024

EthenNotEthan Dec 5, 2024

ian-shim left a comment

ian-shim Dec 12, 2024


		bytes public quorumConfirmationThresholdPercentages;

		bytes public quorumNumbersRequired;


		mapping(uint16 => VersionedBlobParams) public versionedBlobParams;

		SecurityThresholds public defaultSecurityThresholdsV2;

V2 Blob Verification #781

V2 Blob Verification #781

Conversation

0x0aa0 commented Oct 2, 2024 • edited Loading

ian-shim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ian-shim commented Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ian-shim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0x0aa0 commented Oct 2, 2024 •

edited

Loading

ian-shim commented Dec 3, 2024 •

edited

Loading