Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redis]Implement Lockable KVStore #83

Merged
merged 5 commits into from
Nov 29, 2023
Merged

[Redis]Implement Lockable KVStore #83

merged 5 commits into from
Nov 29, 2023

Conversation

siddimore
Copy link
Contributor

Why are these changes needed?

  1. Extend Common.KVStore to be lockable
  2. Implement interface for Local and Redis Store
  3. Remove DynamodB config for RateLimiter in Main.go

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore marked this pull request as ready for review November 29, 2023 14:58
@siddimore siddimore merged commit 38c7b76 into redis_add_lock Nov 29, 2023
1 check passed
teddyknox pushed a commit that referenced this pull request Nov 29, 2023
@mooselumph
Refactor indexer (#83)
5171426
cody-littley added a commit to cody-littley/eigenda that referenced this pull request Jul 15, 2024
@cody-littley
Fix fft_fr.IsPowerOfTwo(). (Layr-Labs#83)
ac86110 
Signed-off-by: Cody Littley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph Awaiting requested review from mooselumph

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@siddimore