Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion between integer types #872

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix conversion between integer types #872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f3fad6
Fix code scanning alert no. 16: Incorrect conversion between integer …
pschork Nov 7, 2024
e873d78
Lint
pschork Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions disperser/dataapi/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/json"
"errors"
"fmt"
"math"
"math/big"
"net/http"
"os"
Expand Down Expand Up @@ -898,35 +899,28 @@ func (s *server) FetchOperatorEjections(c *gin.Context) {
operatorId := c.DefaultQuery("operator_id", "") // If not specified, defaults to all operators

days := c.DefaultQuery("days", "1") // If not specified, defaults to 1
daysInt, err := strconv.Atoi(days)
if err != nil {
parsedDays, err := strconv.ParseInt(days, 10, 32)
if err != nil || parsedDays < math.MinInt32 || parsedDays > math.MaxInt32 {
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid 'days' parameter"})
return
}
daysInt := int32(parsedDays)

first := c.DefaultQuery("first", "1000") // If not specified, defaults to 1000
firstInt, err := strconv.Atoi(first)
if err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid 'first' parameter"})
return
}

if firstInt < 1 || firstInt > 10000 {
parsedFirst, err := strconv.ParseInt(first, 10, 32)
if err != nil || parsedFirst < 1 || parsedFirst > 10000 {
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid 'first' parameter. Value must be between 1..10000"})
return
}
firstInt := int32(parsedFirst)

skip := c.DefaultQuery("skip", "0") // If not specified, defaults to 0
skipInt, err := strconv.Atoi(skip)
if err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid 'skip' parameter"})
return
}

if skipInt < 0 || skipInt > 1000000000 {
parsedSkip, err := strconv.ParseInt(skip, 10, 32)
if err != nil || parsedSkip < 0 || parsedSkip > 1000000000 {
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid 'skip' parameter. Value must be between 0..1000000000"})
return
}
skipInt := int32(parsedSkip)

operatorEjections, err := s.getOperatorEjections(c.Request.Context(), int32(daysInt), operatorId, uint(firstInt), uint(skipInt))
if err != nil {
Expand Down
Loading