Relay Client #875
Merged
Relay Client #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Nov 8, 2024
| @@ -8,7 +8,6 @@ import ( | |||
| grpcnode "github.com/Layr-Labs/eigenda/api/grpc/node" | |||
| "github.com/Layr-Labs/eigenda/core" | |||
| "github.com/Layr-Labs/eigenda/encoding" | |||
| "github.com/Layr-Labs/eigenda/node" | |||
There was a problem hiding this comment.
moved some methods from node/utils.go to core/serialization.go to prevent this client from importing node package
ian-shim
force-pushed
the
relay-client
branch
3 times, most recently
from
113b4c6 to
c6da8ce
Compare
ian-shim
force-pushed
the
relay-client
branch
3 times, most recently
from
36bd63b to
1cd6570
Compare
mooselumph
approved these changes
Nov 13, 2024
api/clients/relay_client.go
Outdated
|
|
||
| type ChunkRequestByIndex struct { | ||
| BlobKey corev2.BlobKey | ||
| Indexes []uint32 |
| // GetChunksByRange retrieves blob chunks from a relay by chunk index range | ||
| // The returned slice has the same length and ordering as the input slice, and the i-th element is the bundle for the i-th request. | ||
| // Each bundle is a sequence of frames in raw form (i.e., serialized core.Bundle bytearray). | ||
| GetChunksByRange(ctx context.Context, relayKey corev2.RelayKey, requests []*ChunkRequestByRange) ([][]byte, error) |
There was a problem hiding this comment.
Should this client handle deserialization?
There was a problem hiding this comment.
It's intentionally left serialized so that caller can use the serialized bytes without serializing it again. (node can directly store the bytearrays without the overhead of serializing them again)
ian-shim
force-pushed
the
relay-client
branch
from
1cd6570 to
e4ed0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Scaffold implementation of client that talks to a set of relay services.
A follow up PR will handle gRPC calls when the interface has been finalized and merged
Checks