Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subgraph README.md typo #890

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix Subgraph README.md typo #890

merged 1 commit into from
Nov 20, 2024

Conversation

gwenall
Copy link
Contributor

@gwenall gwenall commented Nov 13, 2024

Why are these changes needed?

There is a typo int a shell example were there are 4 hyphens instead of 2 on the graph init parameters.
This commit is fixing this typo

Checks

This is a Readme typo.
The command has been tested locally.

There is a typo int a shell example were there are 4 hyphens instead of 2 on the graph init parameters
This commit is fixing this typo
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. My guess is they wanted -- --from-contract ..., but not sure if the -- separation is needed for graph init.

@samlaf samlaf requested a review from jianoaix November 18, 2024 08:46
@jianoaix
Copy link
Contributor

This looks reasonable to me. My guess is they wanted -- --from-contract ..., but not sure if the -- separation is needed for graph init.

from-contract is a normal argument from graph, should not need the -- separation

@jianoaix jianoaix merged commit eef48b6 into Layr-Labs:master Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants