Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc remote bls signer #896

Closed
wants to merge 5 commits into from
Closed

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Nov 14, 2024

Bump's go-ethereum to latet to resolve unit tests

Why?
Unit tests were failing Error: ../../../go/pkg/mod/github.com/gballet/[email protected]/tree.go:960:23: n.commitment.BytesUncompressed undefined (type *banderwagon.Element has no field or method BytesUncompressed)

    go mod graph | grep go-verkle
    github.com/Layr-Labs/eigenda github.com/gballet/[email protected]
    github.com/ethereum/[email protected] github.com/gballet/[email protected]
    github.com/gballet/[email protected] github.com/crate-crypto/[email protected]
    github.com/gballet/[email protected] golang.org/x/[email protected]
    github.com/gballet/[email protected] github.com/bits-and-blooms/[email protected]
    github.com/gballet/[email protected] github.com/consensys/[email protected]
    github.com/gballet/[email protected] github.com/consensys/[email protected]
    github.com/gballet/[email protected] github.com/mmcloughlin/[email protected]
    github.com/gballet/[email protected] golang.org/x/[email protected]
    github.com/gballet/[email protected] rsc.io/[email protected]

Resolves grpc.Dial deprecations due to cerbereus bumping grpc from v1.59.0 -> v1.64.1

  • Updates grpc.Dial -> grpc.NewClient
  • Removes withBlock() option from grpcConnection.Dial used by syntetic checks.

see https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md for why withBlock() was deprecated.

shrimalmadhur and others added 3 commits November 14, 2024 12:21
update docker file for private repo

remove the go private

deps

api

fix  deps

fix flags

fix convert

support latest signer

support latest signer

support latest signer

replace with cerberus

add cert file path

operator id

move log up

move function up

move function up

fix incorrect logic

clean and and make backward compatible

clean up
`[email protected]` indirectly adds an unreleased
`github.com/gballet/[email protected]`
To complicate matters, `github.com/gballet/go-verkle` was moved to
`github.com/ethereum/go-verkle` after `[email protected]`

```
go mod graph | grep go-verkle
github.com/Layr-Labs/eigenda github.com/gballet/[email protected]
github.com/ethereum/[email protected] github.com/gballet/[email protected]
github.com/gballet/[email protected] github.com/crate-crypto/[email protected]
github.com/gballet/[email protected] golang.org/x/[email protected]
github.com/gballet/[email protected] github.com/bits-and-blooms/[email protected]
github.com/gballet/[email protected] github.com/consensys/[email protected]
github.com/gballet/[email protected] github.com/consensys/[email protected]
github.com/gballet/[email protected] github.com/mmcloughlin/[email protected]
github.com/gballet/[email protected] golang.org/x/[email protected]
github.com/gballet/[email protected] rsc.io/[email protected]
```
@pschork pschork force-pushed the pschork/poc-remote-bls-signer branch from 6602029 to d406e94 Compare November 15, 2024 01:08
from v1.63 -> v1.64.

- Updates `grpc.Dial` -> `grpc.NewClient`

- Removes `withBlock()` option from `grpcConnection.Dial` used by syntetic checks.
see https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md for why `withBlock()` was deprecated.
@pschork pschork marked this pull request as ready for review November 15, 2024 03:13
@pschork pschork closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants