Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up v2 EncodingClient in EncodingManager #897

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Set up v2 EncodingClient in EncodingManager #897

merged 1 commit into from
Nov 15, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

  • sets up encoding client in encoding manager
  • removes timeout from the client and uses context in the parameter
  • make controller use EthClient in RPC only mode

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 14, 2024 23:48
@ian-shim ian-shim mentioned this pull request Nov 15, 2024
Closed
5 tasks
@ian-shim ian-shim merged commit 23c9718 into Layr-Labs:master Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@dmanc dmanc dmanc approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @dmanc @cody-littley