Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to v2 api server. #969

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

cody-littley
Copy link
Contributor

Why are these changes needed?

Adds metrics to the v2 api server.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Signed-off-by: Cody Littley <[email protected]>
@cody-littley cody-littley requested a review from ian-shim December 9, 2024 19:51
@cody-littley cody-littley self-assigned this Dec 9, 2024
Signed-off-by: Cody Littley <[email protected]>
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily this PR, but it would be nice to export the number of response types such as 200, 4xx, 5xx

blobStore *blobstore.BlobStore,
blobMetadataStore *blobstore.BlobMetadataStore,
chainReader core.Reader,
ratelimiter common.RateLimiter,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@cody-littley cody-littley merged commit 4a98d98 into Layr-Labs:master Dec 11, 2024
6 checks passed
@cody-littley cody-littley deleted the apiserver-metrics branch December 11, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants