add bls signer abstraction from eigensdk #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrimalmadhur
force-pushed
the
madhur/eigensdk-bls-abstraction-update
branch
2 times, most recently
from
abb4631 to
1c92ed0
Compare
shrimalmadhur
force-pushed
the
madhur/eigensdk-bls-abstraction-update
branch
3 times, most recently
from
2abf113 to
7c7c900
Compare
dmanc
reviewed
Jan 14, 2025
I have tested it with one of my preprod node using the remote signer |
ian-shim
reviewed
Jan 14, 2025
| @@ -96,7 +96,7 @@ func setup(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| logger := logging.NewNoopLogger() | |||
There was a problem hiding this comment.
is NewNoopLogger gone from eigensdk?
There was a problem hiding this comment.
is. it's gone. poof. that's why I had to replace with test logger I defined in test_utils
core/chainio.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
| "math/big" | |||
|
|
|||
| "github.com/Layr-Labs/eigenda/api/grpc/churner" | |||
| sdkSigner "github.com/Layr-Labs/eigensdk-go/signer/bls" | |||
There was a problem hiding this comment.
yea that's better - will update
There was a problem hiding this comment.
actually blssigner (i think package names are all lowercase)
core/eth/writer.go
Outdated
| @@ -62,14 +64,15 @@ func NewWriter( | |||
| func (t *Writer) RegisterOperator( | |||
| ctx context.Context, | |||
| keypair *core.KeyPair, | |||
There was a problem hiding this comment.
can we remove keypair now?
core/eth/writer.go
Outdated
| @@ -102,6 +105,7 @@ func (t *Writer) RegisterOperator( | |||
| func (t *Writer) RegisterOperatorWithChurn( | |||
| ctx context.Context, | |||
| keypair *core.KeyPair, | |||
node/node.go
Outdated
| @@ -76,7 +73,9 @@ type Node struct { | |||
| PubIPProvider pubip.Provider | |||
| OperatorSocketsFilterer indexer.OperatorSocketsFilterer | |||
| ChainID *big.Int | |||
| BLSSigner blssignerV1.SignerClient | |||
| BLSPublicKeyHex string | |||
There was a problem hiding this comment.
do we need this as a separate field? could we infer this from BlsSigner?
There was a problem hiding this comment.
good point. No. will remove
node/node.go
Outdated
| BLSSigner blssignerV1.SignerClient | ||
| BLSPublicKeyHex string | ||
|
|
||
| BlsSigner sdkSigner.Signer |
update eigensdk to that commit upgrade logger to remove noop fix testmode fix nil pointers rebase and fix rebase update to new eigensdk add bls signer to plugin fix unit tests fix g2 point deser fix file signer fix copying remove unused code
shrimalmadhur
force-pushed
the
madhur/eigensdk-bls-abstraction-update
branch
from
b3075cc to
41a573a
Compare
ian-shim
approved these changes
Jan 15, 2025
| @@ -14,7 +14,7 @@ import ( | |||
| "github.com/Layr-Labs/eigenda/encoding/kzg" | |||
| "github.com/Layr-Labs/eigenda/node/flags" | |||
|
|
|||
| "github.com/Layr-Labs/eigensdk-go/crypto/bls" | |||
| blssignerTypes "github.com/Layr-Labs/eigensdk-go/signer/bls/types" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
1.21.13since some dependency needs it. Since it's a patch version upgrades, this should be good.TESTING
Checks