Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changing burnableShares to EnumerableMap #1028

Merged
merged 13 commits into from
Jan 21, 2025
Merged

feat: changing burnableShares to EnumerableMap #1028

merged 13 commits into from
Jan 21, 2025

Conversation

eigenmikem
Copy link

No description provided.

0xClandestine
0xClandestine requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice some minor nits, otherwise LGTM!

src/contracts/core/StrategyManager.sol Outdated Show resolved Hide resolved
src/contracts/core/StrategyManagerStorage.sol Outdated Show resolved Hide resolved
src/contracts/core/StrategyManagerStorage.sol Outdated Show resolved Hide resolved
ypatil12
ypatil12 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming interface is good for @jbrower95

ypatil12
ypatil12 requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also update bindings (make bindings) and add to documentation

ypatil12
ypatil12 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@eigenmikem eigenmikem merged commit 97b9d82 into slashing-magnitudes-fixes Jan 21, 2025
10 of 11 checks passed
@eigenmikem eigenmikem deleted the burnable-shares-enumerablemap branch January 21, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xClandestine 0xClandestine 0xClandestine approved these changes

@ypatil12 ypatil12 ypatil12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eigenmikem @ypatil12 @0xClandestine