Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: slashing factors rounding #1089

Merged

Conversation

0xClandestine
Copy link
Member

Motivation:

Fixes an issue where rounding in slashingFactor calculations can result in a factor of zero, causing stakers to lose all their withdrawable shares under specific edge cases. This can be exploited by malicious operators through intentional self-slashing and small beacon chain penalties. (EGSL-16)

Modifications:

  • Added documentation note informing users of the potential rounding issue with slashingFactor when operatorMaxMagnitude and beaconChainSlashingFactor are extremely small.
  • Implemented frontend warnings for stakers when delegating to operators with extremely low maxMagnitude, helping mitigate potential exploits.

Result:

  • Increased transparency on edge cases that could lead to loss of withdrawable shares.
  • Preventative warnings to stakers to avoid delegation to potentially malicious or risky operators.

@0xClandestine 0xClandestine changed the title Docs/slashing factors rounding docs: slashing factors rounding Feb 12, 2025
@0xClandestine 0xClandestine changed the base branch from dev to slashing-magnitudes-fixes February 12, 2025 17:34
@0xClandestine 0xClandestine force-pushed the docs/slashing-factors-rounding branch from ddcb034 to f75722e Compare February 13, 2025 14:39
@0xClandestine 0xClandestine merged commit 89d477b into slashing-magnitudes-fixes Feb 13, 2025
11 checks passed
@0xClandestine 0xClandestine deleted the docs/slashing-factors-rounding branch February 13, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants