fix: add attribute nil verifications in chainReader #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure is taken from this other PR that tests invalid config: Layr-Labs#447. This is done this way to make easier future merges
|
We should use errors.Wrap |
damiramirez
reviewed
Jan 20, 2025
|
|
||
| _ = contractAddrs | ||
| _ = operator | ||
| _ = chainReader |
There was a problem hiding this comment.
Are we going to use these variables? Otherwise we can remove them
There was a problem hiding this comment.
Comment on lines
760
to
763
| assert.Zero(t, strategy) | ||
| assert.Zero(t, undToken) | ||
| assert.Error(t, err) | ||
| assert.Equal(t, err.Error(), "Failed to fetch token contract: no contract code at given address") |
There was a problem hiding this comment.
If we know that this function will throw an error, is it necessary to check the strategy and undToken?
There was a problem hiding this comment.
No, done in Remove unnecesary asserts
Comment on lines
768
to
772
| assert.Zero(t, strategy) | ||
| assert.Zero(t, methods) | ||
| assert.Zero(t, undToken) | ||
| assert.Error(t, err) | ||
| assert.Equal(t, err.Error(), "Failed to fetch token contract: no contract code at given address") |
There was a problem hiding this comment.
Done in Remove unnecesary asserts
pablodeymo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Some
chainReadermethods currently does not verify that some attributes are not nil before accessing them. This PR aims to fix this and add some test cases covering it.Also renames a variable that had a generic name for a more proper one.
Note: This PR respects structure from #447 and it's recommended to merge after it.
Reviewer Checklist