Slashing

[TomasArrachea]

No description provided.

[supernovahs]

@TomasArrachea there are 2 registerOperator methods in registry coordinator
If we enable operator sets , then we can't use the old method https://github.com/Layr-Labs/eigenlayer-middleware/blob/865b49015652a3dd3ba28b666d15c4a68eb23670/src/RegistryCoordinator.sol#L146

and vice versa
https://github.com/Layr-Labs/eigenlayer-middleware/blob/865b49015652a3dd3ba28b666d15c4a68eb23670/src/RegistryCoordinator.sol#L303

the second case is not covered in the bls agg tests

I am getting these logs with RegistryError when using IS with operator sets enabled

Don't know if its a configuration on my end or its in the bls agg yet

Error: RegistryError
2025-01-02T07:39:49.110866Z  INFO alloy_pubsub::service: Pubsub service request channel closed. Shutting down.
2025-01-02T07:39:59.115455Z  INFO incredible_operator::builder: operator1 picked up a new task , index: 1 
2025-01-02T07:39:59.117673Z  INFO incredible_operator_2::builder: operator2 picked up a new task , index: 1 
2025-01-02T07:39:59.119563Z  INFO incredible_challenger: challenger: picked up a new task 
2025-01-02T07:39:59.172050Z  INFO incredible_aggregator: processed signature for index 1
2025-01-02T07:39:59.172090Z  INFO incredible_aggregator: quorum not reached yet for index:1. waiting to receive more signatures 
thread 'http.worker0' panicked at /Users/supernovahs/Desktop/eigenlabs/incredible-squaring-avs-rs/crates/aggregator/src/lib.rs:301:20:
PROCESS_SIGNATURE_ERROR: SignaturesChannelClosed
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2025-01-02T07:40:09.119369Z  INFO incredible_operator::builder: operator1 picked up a new task , index: 2 
2025-01-02T07:40:09.121949Z  INFO incredible_operator_2::builder: operator2 picked up a new task , index: 2 
2025-01-02T07:40:09.123924Z  INFO incredible_challenger: challenger: picked up a new task 
2025-01-02T07:40:09.173928Z  INFO incredible_aggregator: processed signature for index 2
2025-01-02T07:40:09.173954Z  INFO incredible_aggregator: quorum not reached yet for index:2. waiting to receive more signatures 
thread 'http.worker0' panicked at /Users/supernovahs/Desktop/eigenlabs/incredible-squaring-avs-rs/crates/aggregator/src/lib.rs:301:20:
PROCESS_SIGNATURE_ERROR: SignaturesChannelClosed
2025-01-02T07:40:19.126919Z  INFO incredible_operator::builder: operator1 picked up a new task , index: 3 
2025-01-02T07:40:19.129211Z  INFO incredible_operator_2::builder: operator2 picked up a new task , index: 3 
2025-01-02T07:40:19.131801Z  INFO incredible_challenger: challenger: picked up a new task 
2025-01-02T07:40:19.187593Z  INFO incredible_aggregator: processed signature for index 3
2025-01-02T07:40:19.187620Z  INFO incredible_aggregator: quorum not reached yet for index:3. waiting to receive more signatures 
thread 'http.worker0' panicked at /Users/supernovahs/Desktop/eigenlabs/incredible-squaring-avs-rs/crates/aggregator/src/lib.rs:301:20:
PROCESS_SIGNATURE_ERROR: SignaturesChannelClosed

[supernovahs]

issue resolved
was solidity division issue , shares were not in 1e18 precision
https://github.com/Layr-Labs/eigenlayer-middleware/blob/512ce7326f35e8060b9d46e23f9c159c0000b546/src/StakeRegistry.sol#L484

[MegaRedHand]

LGTM, but some functions from the Go SDK are missing:

• GetOperatorAVSSplit
• GetOperatorPISplit
• SetOperatorAVSSplit
• SetOperatorPISplit
• ProcessClaims
• ForceDeregisterFromOperatorSets
• NewRemovePermissionTx
• NewSetPermissionTx
• NewAcceptAdminTx
• NewAddPendingAdminTx
• NewRemoveAdminTx
• NewRemovePendingAdminTx

Also, some reader functions were implemented on the writer:

• GetDistributionRootsLength
• CurrRewardsCalculationEndTimestamp
• GetCurrentClaimableDistributionRoot
• GetRootIndexFromHash
• GetCumulativeClaimed
• CheckClaim

I will work on this on different PRs to avoid muddying this PR.