Skip to content

Commit

Permalink
Fix release build
Browse files Browse the repository at this point in the history
  • Loading branch information
seanmcgary committed Nov 14, 2024
1 parent e23cc8b commit bde8e7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,10 @@ jobs:
else
docker buildx build --platform $PLATFORMS -t $REGISTRY/$REPOSITORY:$VERSION --push .
fi
build-binary:
build-create-release:
runs-on: ubuntu-latest
needs: [lint, test]
if: startsWith(github.ref, 'refs/tags/')
permissions: write-all
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -107,16 +108,9 @@ jobs:
- name: Build binary
run: |
VERSION=$(cat .release_version)
echo "Building binary for version $VERSION"
make release
./scripts/bundleReleases.sh $VERSION
create-release:
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/')
needs: [build-binary]
permissions: write-all
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Create Release
id: create_release
uses: actions/create-release@v1
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

GO=$(shell which go)
ALL_FLAGS=
GO_FLAGS=-ldflags "-X 'github.com/Layr-Labs/sidecar/internal/version.Version=$(shell cat .release_version || "unknown")' -X 'github.com/Layr-Labs/sidecar/internal/version.Commit=$(shell git rev-parse --short HEAD)'"
GO_FLAGS=-ldflags "-X 'github.com/Layr-Labs/sidecar/internal/version.Version=$(shell cat .release_version)' -X 'github.com/Layr-Labs/sidecar/internal/version.Commit=$(shell git rev-parse --short HEAD)'"

deps/dev:
${GO} install github.com/golangci/golangci-lint/cmd/[email protected]
Expand Down

0 comments on commit bde8e7f

Please sign in to comment.