Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UserInput::Sequence and InputInterval #485

Open
Shute052 opened this issue Feb 22, 2024 · 4 comments
Open

Add UserInput::Sequence and InputInterval #485

Shute052 opened this issue Feb 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Shute052
Copy link
Collaborator

Shute052 commented Feb 22, 2024

Allows users to define a specific pattern of inputs.

let throttled_double_click = UserInput::Sequence {
   pattern: vec![MouseButton::Left, MouseButton::Left],
   intervals: vec![InputInterval::Range(50ms, 200ms)],
});

let invincible_cheat_keys = UserInput::sequence(vec![Up, Up, Down, Down, Left, Right, Left, Right, B, A, B, A]);

With these:

pub enum InputInterval {
    None,
    AtLeast(milliseconds),
    AtMost(milliseconds),
    Range(min_milliseconds, max_milliseconds),
}
@Shute052 Shute052 added the usability Reduce user friction label Feb 22, 2024
@alice-i-cecile alice-i-cecile added enhancement New feature or request and removed usability Reduce user friction labels Feb 22, 2024
@alice-i-cecile
Copy link
Contributor

Previously: #49 :) I'll close that out: this is a better name.

P.S. This gets the enhancement label, since it's a whole new feature.

@Shute052 Shute052 changed the title UserInput::Sequence Add UserInput::Sequence Feb 23, 2024
@Shute052 Shute052 changed the title Add UserInput::Sequence Add UserInput::Sequence and InputInterval Feb 23, 2024
@Shute052
Copy link
Collaborator Author

Shute052 commented Feb 23, 2024

This should halt its implementation stage before #483.
Otherwise, it will make the current internal system extremely complex.

@RomainMazB
Copy link

As far as I understand, this issue was blocked by #483 which was somewhat replaced by #534 which was merged.

So is the blocked label still accurate?

@alice-i-cecile alice-i-cecile removed the blocked Nothing to do yet label Aug 11, 2024
@alice-i-cecile
Copy link
Contributor

Good catch: this is no longer blocked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants