Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arpeggios #49

Closed
alice-i-cecile opened this issue Jan 27, 2022 · 4 comments
Closed

Add arpeggios #49

alice-i-cecile opened this issue Jan 27, 2022 · 4 comments
Labels
controversial Requires a heightened standard of review enhancement New feature or request

Comments

@alice-i-cecile
Copy link
Contributor

alice-i-cecile commented Jan 27, 2022

Needs:

@alice-i-cecile alice-i-cecile added the enhancement New feature or request label Jan 27, 2022
@alice-i-cecile alice-i-cecile added this to the 0.3 milestone Feb 9, 2022
@johanhelsing
Copy link
Contributor

How will arpeggios work? will it be able to say that

  • ctrl down, alt down, p down should trigger the action
  • alt down, ctrl down, p down should trigger the action
  • p down, ctrl down, alt down should not trigger the action

Or maybe I'd need to add two arpeggios? one for alt+ctrl and one for ctrl+alt?

@alice-i-cecile
Copy link
Contributor Author

Or maybe I'd need to add two arpeggios? one for alt+ctrl and one for ctrl+alt?

This is the idea. I intend to add builder methods to make that easy, along with a reasonable "modifier key" setup which does this automatically.

If there were likely to be arpeggios of more than three inputs, with this sort of branching logic, I'd add a graph-builder API, but I think that's dramatically over-engineering here 😄

@alice-i-cecile
Copy link
Contributor Author

Arpeggios should chain as long as there no gap between adjacent inputs.

@alice-i-cecile
Copy link
Contributor Author

Closing in favor of #485.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial Requires a heightened standard of review enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants