Update UpdateLeantime.php #2844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check of the retval of exec('cp') in case, like in 3.3.1, it fails for some reason. In 3.3.1, it was trying to cp from .../cache/leantime/* but the new files were unzipped into the folder .../cache/*
Also, added a try/catch block around ZipArchive because it was not installed by default on my system. With the try/catch block, a nice error message can be displayed for the user
|
|
marcelfolaron
requested changes
Dec 5, 2024
|
A c is missing in io->success('New update zip file - line 130. |
|
Apart from that and this unrelated output, it worked. Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check of the retval of exec('cp') in case, like in 3.3.1, it fails for some reason. In 3.3.1, it was trying to cp from .../cache/leantime/* but the new files were unzipped into the folder .../cache/* Also, added a try/catch block around ZipArchive because it was not installed by default on my system. With the try/catch block, a nice error message can be displayed for the user
Description
Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
Link to ticket
Please add a link to the GitHub issue being addressed by this change.
[Bug]: bin/leantime system:update does not update #2838
Type
Screenshot of the result
If your change affects the user interface, you should include a screenshot of the result with the pull request.