Upgrade to learnlib 0.17.0 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you have adapted to slf4j in the remaining code, i think the most reasonable approach would be to return a |
Temporarily comment out Enum code which does not work anymore with learnlib 0.17.0. The parts that will have to be rewritten are currently commented out and marked with a `FIXME` note.
kostis
force-pushed
the
learnlib-0.17.0
branch
from
999538d to
2a809e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to use the newly released learnlib-0.17.0.
With the exception of one file (out of 140), most of the changes are OK, I thnk.
Help is needed (@fhowar @mtf90) to properly adapt the code of
AbstractToolWithRandomWalk.java.To simplify things, changes to this file are separated from the rest and appear in the second to last commit (the one titled
Temporary fix to AbstractToolWithRandomWalk)