Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Output VERSION_FULL #26

Merged
merged 9 commits into from
Jan 10, 2024
Merged

feat: Output VERSION_FULL #26

merged 9 commits into from
Jan 10, 2024

Conversation

LecrisUT
Copy link
Owner

@LecrisUT LecrisUT commented Jan 9, 2024

  • Added missing tests
  • Construct the VERSION_FULL if not available: either DEV or POST
  • Import version from python's sdist PKG-INFO

Closes: #24

Copy link

github-actions bot commented Jan 9, 2024

Test Results

 3 files  ±0   3 suites  ±0   2m 30s ⏱️ + 2m 2s
 6 tests +1   6 ✅ +1  0 💤 ±0  0 ❌ ±0 
18 runs  +3  18 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit c4a3ce3. ± Comparison against base commit 6728e31.

♻️ This comment has been updated with latest results.

@LecrisUT LecrisUT force-pushed the feat/DynamicVersion-full branch 2 times, most recently from fc97f95 to 73d962e Compare January 10, 2024 17:14
- Allow to compute from python `sdist`
- More explicit regex
- Calculate version-full as dev/post format
- Simplify the order

Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT force-pushed the feat/DynamicVersion-full branch from 73d962e to 29102d5 Compare January 10, 2024 18:16
@LecrisUT LecrisUT force-pushed the feat/DynamicVersion-full branch from 29102d5 to a1bcd6c Compare January 10, 2024 18:41
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT LecrisUT force-pushed the feat/DynamicVersion-full branch from a1bcd6c to c4a3ce3 Compare January 10, 2024 18:45
@LecrisUT LecrisUT merged commit 24add72 into main Jan 10, 2024
14 of 15 checks passed
@LecrisUT LecrisUT deleted the feat/DynamicVersion-full branch January 10, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating full_version
1 participant