App version 1.0.5 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ledger hq changes, change icons
Build improvements, Speculos tests
They behave similar to hash functions
The code now pases original integration tests
This way derivation path is available for DH encoding
Changing newfundsreq data content format, introduce error specific to integrity checks.
applying parse not validate as it is supposed
Derivation path is serializes LE Remove unnecessary endian functions
List of hashes for integrity check is not updated at the moment...
Do not show their pubkey and our path. Fix issue with swapped payer and payee public address in recordobt
Change DH texts
Modify string in decrypt
Splits the mapping into multiple screens
Extend addnft and remnft token_id parameter
Align master with develop
Various code improvements fixing issues found during internal security reveiw,
…eanup Documentation and cleanup
…eanup Fix on device get app version test
Fixed: - Missing input value validation - Potential missing secret wiping from stack after use - String manipulation - Pointer arithmetic on void pointer - Trivial swich-case statements were removed - Replaced certain other memset calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from #12 up to commit
937b5b943122c6d32c020197251e5c4bf97bf4eb.Include an additional commit adding the
ledger_app.tomlmanifest.Linked to https://ledgerhq.atlassian.net/browse/B2CA-1374