BC2A-1408: Fix duplicate symbols #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
a51c7b2 to
b577bb9
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
6 times, most recently
from
d36bc52 to
afbe845
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
10 times, most recently
from
24dd4b3 to
d9287e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9 +/- ##
========================================
Coverage 94.13% 94.14%
========================================
Files 10 10
Lines 716 717 +1
========================================
+ Hits 674 675 +1
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
5 times, most recently
from
d89fd3d to
bacb3a1
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
bacb3a1 to
e61e04f
Compare
|
@cedelavergne-ledger Sorry to ask you to do it but I think it would be good to add the guideline enforcer ? Even if it fails ? 🤔 |
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
02ccc59 to
7be2ee0
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
7be2ee0 to
e324663
Compare
Done. Some errors will have to be handled separately (mainly DEPRECATED functions) |
sgliner-ledger
previously approved these changes
Nov 13, 2023
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
bb7a5f5 to
9e3d1b4
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
3355ada to
41ac2c1
Compare
sgliner-ledger
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup glyphs:
giffiles from sdkglyphs.[ch]files fromsrc/directoryglyphs.hinunit-tests/to fix compilation issueThis PR also updates the version
Cleanup the workflows and fix the warnings
Adding the
guideline_enforcerworkflow. It fails due to:scan-buildfails on the latest NanoS SDK, because of macro redefinition:UNUSEDscan-buildfails on the latest NanoSP and NanoX, because ofDEPRECATEDcrypto functionsCorrections will be done in another ticket...