Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.4 stable version #11

Merged
merged 21 commits into from
Jul 22, 2024
Merged

1.7.4 stable version #11

merged 21 commits into from
Jul 22, 2024

Conversation

lpascal-ledger
Copy link

No description provided.

Xavier Chapron and others added 21 commits April 4, 2024 18:08
src: onboarding_seed_sskr.c: Use stable cx_crc32 instead of cx_crc32_hw
src: interpolate.c: Fix build with SDK master for LNS
Changed Second Montgomery constant to a more suitable value
 v1.7.4-rc.1 : Use internal `bn_gf2_n_mul()`  function instead of `cx_bn_gf2_n_mul()` syscall
v1.7.4-rc.2 : Ensure result does not overlap with operands in calls to `cx_bn_gf2_n_mul()`
version 2 sskr uses IANA registered CBOR tag #6.40309 updated from deprecared version 1 crypto-sskr tag #309
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@315ec8d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/sskr/sskr.c 66.66% 3 Missing ⚠️
src/sskr/sss/sss.c 83.33% 1 Missing ⚠️
src/ux_common/onboarding_seed_sskr.c 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   82.18%           
=========================================
  Files             ?        5           
  Lines             ?      696           
  Branches          ?        0           
=========================================
  Hits              ?      572           
  Misses            ?      124           
  Partials          ?        0           
Flag Coverage Δ
unittests 82.18% <92.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpascal-ledger lpascal-ledger merged commit 1d810cc into master Jul 22, 2024
531 of 534 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants