Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo ledger setup step to full / legacy images. #86

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add cargo ledger setup step to full / legacy images. #86

merged 1 commit into from
Oct 3, 2023

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Oct 2, 2023 •
edited
Loading

  • Add cargo ledger setup to full/legacy images so users don't have to do it before being able to build apps.
  • Add workaround to https://github.com/curl/curl/issues/11917 so that curl still works properly.
  • Remove apk add curl from dev-tools image, it is already installed in full image.

@agrojean-ledger agrojean-ledger force-pushed the add-cargo-ledger-setup branch 2 times, most recently from 1f4a7ed to 2764afc Compare October 2, 2023 12:13
xchapron-ledger
xchapron-ledger approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's not just a patch bump?
Also the title of the Pr / commit could be update?
Else Looks good to me.

@agrojean-ledger agrojean-ledger changed the title Add cargo ledger setup step to full image. Add cargo ledger setup step to full / legacy images. Oct 2, 2023
@agrojean-ledger
Copy link
Contributor Author

agrojean-ledger commented Oct 2, 2023 •
edited
Loading

Maybe it's not just a patch bump? Also the title of the Pr / commit could be update? Else Looks good to me.

Done. @xchapron-ledger

@agrojean-ledger agrojean-ledger merged commit 2084d9b into master Oct 3, 2023
6 checks passed
@agrojean-ledger agrojean-ledger deleted the add-cargo-ledger-setup branch October 3, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrojean-ledger @xchapron-ledger