ci: fixes

LedgerHQ · Jun 20, 2024 · 96091ca · 96091ca
1 parent cdaae0e
commit 96091ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -50,17 +50,16 @@ jobs:
         name: Validate files and format
         if: ${{ success() && github.event_name == 'pull_request' }}
         id: validation
-        continue-on-error: true
         shell: bash
         run: |
           echo 'validation_output<<EOF' >> $GITHUB_OUTPUT
           pipenv run validate_files >> $GITHUB_OUTPUT
-          ret=$?
+          [[ $? ]] && result="success" || result="failure"
           echo 'EOF' >> $GITHUB_OUTPUT
-          exit $ret
+          echo "result=$result" >> $GITHUB_OUTPUT
 
       - name: Add failure report comment
-        if: ${{ steps.validation.outcome != 'success' && github.event_name == 'pull_request' }}
+        if: ${{ steps.validation.outputs.result != 'success' && github.event_name == 'pull_request' }}
         uses: thollander/actions-comment-pull-request@v2
         with:
           comment_tag: validation_result
@@ -79,7 +78,7 @@ jobs:
             </pre>
 
       - name: Add success report comment
-        if: ${{ steps.validation.outcome == 'success' && github.event_name == 'pull_request' }}
+        if: ${{ steps.validation.outputs.result == 'success' && github.event_name == 'pull_request' }}
         uses: thollander/actions-comment-pull-request@v2
         with:
           comment_tag: validation_result

diff --git a/arbitrum/permit/eip712.json b/arbitrum/permit/eip712.json
@@ -31,7 +31,7 @@
                         "label": "Permit USDC (bridged) transfers"
                     },
                     "schema": {
-                        "EIP712Domain": [
+                        "EIP712Dodmain": [
                             {
                                 "name": "name",
                                 "type": "string"