Add Uniswap b2c.json files for nano app external plugin
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@lambertkevin the ABI files need to be renamed to .abi.json
lambertkevin
force-pushed
the
feature/add-uniswap-b2c-files
branch
from
a3cc3b7 to
f3a4cd6
Compare
|
@jnicoulaud-ledger My bad ! Fixed ! 👌 |
lambertkevin
force-pushed
the
feature/add-uniswap-b2c-files
branch
from
f3a4cd6 to
5fc34a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the new Uniswap external plugin we need the signature capable of launching the external plugin
Uniswapwith the selector of itsexecutemethod (https://etherscan.io/address/0x3fc91a3afd70395cd496c647d5a6cc9d4b2b7fad#writeContract#F3).No other information is required (like
erc20OfInterestor ABIs) as the tokens involved are not retrievable via ABI decoding, but require manual parsing, which will be done in@ledgerhq/hw-app-eth.