rework MultiFieldReview to use less stack #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhql
force-pushed
the
fix/multifield_stack
branch
from
d36653e to
c85cda1
Compare
dj8yfo
reviewed
Jan 19, 2024
yhql
force-pushed
the
fix/multifield_stack
branch
from
c85cda1 to
24e2d96
Compare
yhql
force-pushed
the
fix/multifield_stack
branch
from
24e2d96 to
265f326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preallocating 48 Pages led to a huge stack usage and to crashes on Nano S.
This gadget was reworked so that it does not preallocate, and makes it "simpler" to visualize Fields by giving them their own widget (similar to MessageScroller in behaviour, except with a counter and a different amount of lines used).
Note that
MAX_LINESwas changed to4(was previously3) for Nano X/S+ to avoid ifdefs to match the C version of the Field view, but as a consequence, a Menu now displays over 4 lines.