Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NVMData on S+; add a new symbol at start of .nvm_data #130

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

dfordivam
Copy link
Contributor

No description provided.

@yogh333 yogh333 requested a review from yhql February 8, 2024 09:26
@dfordivam
Copy link
Contributor Author

I think that it should also be modified there also

@yogh333 I think at this point the size calculation is happening for the mutable portion of flash memory, which can be written by the nvm_write, and is correct; considering that the symbol is used to cover the .rodata section also.

@yogh333 yogh333 merged commit 34a07a5 into LedgerHQ:master Feb 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants