Skip to content

Commit

Permalink
fixup! fixup! feat(xrp): add memos and destinationTag to xrp crafts
Browse files Browse the repository at this point in the history
  • Loading branch information
@jprudent
jprudent committed Feb 4, 2025
1 parent ed7ea23 commit 8ed2cd3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .changeset/calm-deers-smile.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@ledgerhq/coin-xrp": major
"@ledgerhq/coin-framework": major
---

Evolve transaction type to allow arbitrary crafting properties
5 changes: 0 additions & 5 deletions .changeset/tame-experts-film.md
View file

This file was deleted.

1 comment on commit 8ed2cd3

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($111.32) ⏲ 41s

✅ 1 specs are successful: XRP

What is the bot and how does it work? Everything is documented here!

Details of the 1 mutations

Spec XRP (5)

Spec XRP found 5 XRP accounts. Will use XRP 2.4.2 on nanoS 2.1.0
undefined: 1.08088 XRP (200ops) (r9etPtq3oboweMPju5gdYufmvwhH2euz8z on 44'/144'/0'/0/0) #0 js:2:ripple:r9etPtq3oboweMPju5gdYufmvwhH2euz8z:
undefined: 1.10653 XRP (200ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH:
undefined: 2.95945 XRP (200ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
undefined: 38.8558 XRP (41ops) (rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC on 44'/144'/3'/0/0) #3 js:2:ripple:rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC:
undefined: 0 XRP (0ops) (rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu on 44'/144'/4'/0/0) #4 js:2:ripple:rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu:
necessary accounts resynced in 0.21ms
▬ XRP 2.4.2 on nanoS 2.1.0
→ FROM undefined: 1.10653 XRP (200ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH: (! sum of ops -9.012271 XRP)
max spendable ~0.106527
★ using mutation 'move ~50%'
→ TO undefined: 2.95945 XRP (200ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
✔️ transaction 
SEND 0.053888 XRP
TO rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn
with fee=0.00001 XRP
  tag=123
STATUS (2012ms)
  amount: 0.053888 XRP
  estimated fees: 0.00001 XRP
  total spent: 0.053898 XRP
errors: 
warnings: 
✔️ has been signed! (3.8s) 
✔️ broadcasted! (166ms) optimistic operation: 
  -0.053888 XRP      OUT        8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
✔️ operation confirmed (11.2s): 
  -0.053898 XRP      OUT        8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
✔️ undefined: 1.05263 XRP (201ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH: (! sum of ops -9.066169 XRP)(in 11.2s)
✔️ destination operation 
  +0.053888 XRP      IN         8823854FA1B2CC58C815FDE7D6CE9BC114EAA0CA7362A56D8FD8E83EB69D8277 2025-02-05T10:30
(in 11.2s)
Portfolio ($111.32) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
XRP (5) 643 ops (+2), 40.0027 XRP ($111.32) 💪 999+ r9etPtq3oboweMPju5gdYufmvwhH2euz8z 
undefined: 1.08088 XRP (200ops) (r9etPtq3oboweMPju5gdYufmvwhH2euz8z on 44'/144'/0'/0/0) #0 js:2:ripple:r9etPtq3oboweMPju5gdYufmvwhH2euz8z:
undefined: 1.05263 XRP (201ops) (rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH on 44'/144'/1'/0/0) #1 js:2:ripple:rX5hKMbYJ2HmKV8se7b2QbbXRiPYArbkH:
undefined: 3.01334 XRP (201ops) (rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn on 44'/144'/2'/0/0) #2 js:2:ripple:rMoFGec38toFg9ncbi9YbrYYmrP3G5exqn:
undefined: 38.8558 XRP (41ops) (rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC on 44'/144'/3'/0/0) #3 js:2:ripple:rrnxW3THwB1ubsE9V78Lek6V1XYnNrodxC:
undefined: 0 XRP (0ops) (rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu on 44'/144'/4'/0/0) #4 js:2:ripple:rPX1z7bA8Mz7KQHetnwuqbEQMGApv8XKAu:
Performance ⏲ 41s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 0.77ms 7.1s 0.90ms 2012ms 3.8s 166ms 11.2s 11.2s
XRP (4) 0.77ms 7.1s 0.90ms 2012ms 3.8s 166ms 11.2s 11.2s

What is the bot and how does it work? Everything is documented here!

Please sign in to comment.