Skip to content

Commit

Permalink
Merge branch 'develop' of github.com:LedgerHQ/ledger-live into feat/s…
Browse files Browse the repository at this point in the history
…upport-app-install
  • Loading branch information
chrisduma-ledger committed Nov 19, 2024
2 parents 5c4455f + 416a171 commit e383880
Show file tree
Hide file tree
Showing 32 changed files with 169 additions and 105 deletions.
5 changes: 0 additions & 5 deletions .changeset/blue-files-train.md

This file was deleted.

2 changes: 1 addition & 1 deletion .changeset/bright-icons-explode.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@ledgerhq/live-common": patch
"@ledgerhq/live-common": minor
---

add uniswap data
2 changes: 1 addition & 1 deletion .changeset/chilly-eggs-hammer.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

Fix icon for stake on Tron account screen
2 changes: 1 addition & 1 deletion .changeset/cyan-experts-raise.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

MEV Protection
4 changes: 2 additions & 2 deletions .changeset/few-owls-cross.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
"ledger-live-desktop": minor
"live-mobile": minor
---

Add a fallback to the provider display name from the firebase JSON if there is no translated title for the given provider. Required to add new providers like Coinbase to EVM staking.
2 changes: 1 addition & 1 deletion .changeset/five-waves-promise.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

Some icons on allocation screen were not well displayed. So change to use ParentCurrencyIcon component (same as the one on the portfolio)
2 changes: 1 addition & 1 deletion .changeset/good-boxes-boil.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

fix redirecting to GITHUB_ENV in fastfile for ios build and setting the build number correctly for slack notification
6 changes: 3 additions & 3 deletions .changeset/long-fireants-cheer.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@ledgerhq/types-live": patch
"ledger-live-desktop": patch
"@ledgerhq/live-common": patch
"@ledgerhq/types-live": minor
"ledger-live-desktop": minor
"@ledgerhq/live-common": minor
---

MEV Protection feature
2 changes: 1 addition & 1 deletion .changeset/loud-pumas-fix.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@ledgerhq/live-common": patch
"@ledgerhq/live-common": minor
---

enable wallet connect for rsk
4 changes: 2 additions & 2 deletions .changeset/mean-pugs-hang.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
"ledger-live-desktop": minor
"live-mobile": minor
---

Add discreetMode param for buy/sell
2 changes: 1 addition & 1 deletion .changeset/metal-walls-rush.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"live-mobile": minor
"@ledgerhq/live-common": patch
"@ledgerhq/live-common": minor
---

Truncate some coins memo on the recipient step of the send flow
2 changes: 1 addition & 1 deletion .changeset/mighty-points-hope.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

Fixes buy/sell navigation paths
5 changes: 5 additions & 0 deletions .changeset/moody-deers-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": minor
---

use feature flag for send flow intermediary screen memo tag
4 changes: 2 additions & 2 deletions .changeset/orange-radios-thank.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"ledger-live-desktop": patch
"live-mobile": patch
"ledger-live-desktop": minor
"live-mobile": minor
---

Persistent sync error on LLD after backup deletion from LLM
2 changes: 1 addition & 1 deletion .changeset/red-bobcats-leave.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

Remove commas from XRP summary tag
2 changes: 1 addition & 1 deletion .changeset/rotten-months-glow.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"live-mobile": patch
"live-mobile": minor
---

Fix crash on non valid memo field in Android
2 changes: 1 addition & 1 deletion .changeset/seven-nails-knock.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"ledger-live-desktop": patch
"ledger-live-desktop": minor
---

Localised URL
4 changes: 2 additions & 2 deletions .changeset/shaggy-shoes-beg.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"ledger-live-desktop": patch
"@ledgerhq/live-common": patch
"ledger-live-desktop": minor
"@ledgerhq/live-common": minor
---

Add translation for troubleshooting network
4 changes: 2 additions & 2 deletions .changeset/small-hairs-flow.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"@ledgerhq/coin-solana": patch
"@ledgerhq/live-common": patch
"@ledgerhq/coin-solana": minor
"@ledgerhq/live-common": minor
---

fix: solana priority fees
4 changes: 2 additions & 2 deletions .changeset/smart-items-laugh.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"live-mobile": patch
"@ledgerhq/live-common": patch
"live-mobile": minor
"@ledgerhq/live-common": minor
---

fix: better logic and guard against accessing null db
2 changes: 1 addition & 1 deletion .changeset/sour-badgers-matter.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"ledger-live-desktop": patch
"ledger-live-desktop": minor
---

Optimize content card log impression based on 50% of the card seen
2 changes: 1 addition & 1 deletion .changeset/sweet-needles-kiss.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"ledger-live-desktop": patch
"ledger-live-desktop": minor
---

Redirect users to Recover Login if they have an account as they may be logged out
6 changes: 3 additions & 3 deletions .changeset/tall-moons-invent.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@ledgerhq/types-live": patch
"live-mobile": patch
"@ledgerhq/live-common": patch
"@ledgerhq/types-live": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
---

Add swap live app webview behind feature flag
6 changes: 3 additions & 3 deletions .changeset/ten-pigs-dress.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
"@ledgerhq/coin-stacks": patch
"live-mobile": patch
"@ledgerhq/live-common": patch
"@ledgerhq/coin-stacks": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
---

support: move stacks to its own coin module
4 changes: 2 additions & 2 deletions .changeset/tiny-feet-type.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
"@ledgerhq/types-live": patch
"@ledgerhq/live-common": patch
"@ledgerhq/types-live": minor
"@ledgerhq/live-common": minor
---

New feature flag for new add account workflow
12 changes: 6 additions & 6 deletions .changeset/unlucky-boats-bow.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
"@ledgerhq/types-live": patch
"@ledgerhq/live-countervalues-react": patch
"ledger-live-desktop": patch
"live-mobile": patch
"@ledgerhq/live-common": patch
"@ledgerhq/live-countervalues": patch
"@ledgerhq/types-live": minor
"@ledgerhq/live-countervalues-react": minor
"ledger-live-desktop": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
"@ledgerhq/live-countervalues": minor
---

Add Granularity rate for Countervalues historical requests cache optimization
8 changes: 4 additions & 4 deletions .changeset/wild-chefs-smash.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
"@ledgerhq/coin-filecoin": patch
"ledger-live-desktop": patch
"live-mobile": patch
"@ledgerhq/live-common": patch
"@ledgerhq/coin-filecoin": minor
"ledger-live-desktop": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
---

support: move filecoin to its own coin module
43 changes: 43 additions & 0 deletions .github/workflows/changeset-enforce.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: No patch level changesets
on:
pull_request

jobs:
check_changesets:
runs-on: ubuntu-22.04

steps:
- name: Checkout repository (feature branch)
uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
fetch-depth: 200

- name: Fetch develop branch
run: |
git fetch origin develop:develop --depth=1
- name: Verify develop branch
run: git branch --all

- uses: pnpm/action-setup@v4
with:
version: 9.12.3

- name: Install changesets
run: pnpm add -g @changesets/[email protected]

- name: Generate changeset status
run: pnpm changeset status --output=changeset-status.json

- name: Check for patch level changesets
run: |
PATCH_CHANGESET_IDS=$(jq -r '.changesets[] | select(.releases[].type == "patch") | .id' changeset-status.json)
if [ -n "$PATCH_CHANGESET_IDS" ]; then
echo "Patch changesets found:"
echo "$PATCH_CHANGESET_IDS"
echo "❌ Patch level changesets are reserved for hotfixes, use major or minor only"
exit 1
else
echo "✅ No patch level changesets found."
fi
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { Flex, Text } from "@ledgerhq/react-ui";
import CheckBox from "~/renderer/components/CheckBox";
import { alwaysShowMemoTagInfoSelector } from "~/renderer/reducers/application";
import { toggleShouldDisplayMemoTagInfo } from "~/renderer/actions/application";
import { useFeature } from "@ledgerhq/live-common/featureFlags/index";

const StepRecipient = ({
t,
Expand All @@ -48,6 +49,7 @@ const StepRecipient = ({
}: StepProps) => {
const isMemoTagBoxVisibile = useSelector(memoTagBoxVisibilitySelector);
const forceAutoFocusOnMemoField = useSelector(forceAutoFocusOnMemoFieldSelector);
const lldMemoTag = useFeature("lldMemoTag");

if (!status || !account) return null;

Expand All @@ -63,7 +65,7 @@ const StepRecipient = ({
currencyName={currencyName}
isNFTSend={isNFTSend}
/>
{isMemoTagBoxVisibile ? (
{isMemoTagBoxVisibile && lldMemoTag?.enabled ? (
<MemoTagSendInfo />
) : (
<>
Expand Down Expand Up @@ -140,6 +142,7 @@ export const StepRecipientFooter = ({
transaction,
}: StepProps) => {
const dispatch = useDispatch();
const lldMemoTag = useFeature("lldMemoTag");
const { errors } = status;
const mainAccount = account ? getMainAccount(account, parentAccount) : null;
const isTerminated = mainAccount && mainAccount.currency.terminated;
Expand All @@ -151,6 +154,7 @@ export const StepRecipientFooter = ({

const handleOnNext = async () => {
if (
lldMemoTag?.enabled &&
!transaction?.memo &&
MEMO_TAG_COINS.includes(transaction?.family as string) &&
alwaysShowMemoTagInfo
Expand Down Expand Up @@ -187,7 +191,7 @@ export const StepRecipientFooter = ({
dispatch(toggleShouldDisplayMemoTagInfo(!alwaysShowMemoTagInfo));
};

return isMemoTagBoxVisibile ? (
return isMemoTagBoxVisibile && lldMemoTag?.enabled ? (
<Flex justifyContent="space-between" width="100%">
<Flex alignItems="center">
<CheckBox isChecked={!alwaysShowMemoTagInfo} onChange={handleOnCheckboxChange} />
Expand Down
Loading

0 comments on commit e383880

Please sign in to comment.