Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: injective integration #4583

Merged
merged 4 commits into from
Sep 18, 2023
Merged

feat: injective integration #4583

merged 4 commits into from
Sep 18, 2023

Conversation

hedi-edelbloute
Copy link
Member

@hedi-edelbloute hedi-edelbloute commented Sep 5, 2023

📝 Description

What this PR does :

  • Integrate injective currency
  • Since it's an ethermint chain, I needed to use @zondax/ledger-cosmos-js lib as cosmjs use not updated yet (and they use zondax lib anyway, so let's use it directly)
  • I removed two duplicated methods : buildUnsignedPayloadTransaction and postBuildUnsignedPayloadTransaction as they do the same as buildTransaction (now txToMessages) and postBuildTransaction (now buildTransaction) with different/partial inputs (one case uses nano input and the other one node info without fees as that's the goal of the estimation)

❓ Context

  • Impacted projects: LLC,LLD,LLM
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-8106

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

image

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ledger-live-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 1:12pm
live-common-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 1:12pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 1:12pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 1:12pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 1:12pm

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 213a009

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@ledgerhq/types-cryptoassets Minor
@ledgerhq/cryptoassets Minor
@ledgerhq/types-live Minor
ledger-live-desktop Minor
live-mobile Minor
@ledgerhq/live-common Minor
@ledgerhq/live-cli Minor
web-tools Patch
@ledgerhq/coin-algorand Patch
@ledgerhq/coin-evm Patch
@ledgerhq/coin-framework Patch
@ledgerhq/coin-polkadot Patch
@ledgerhq/domain-service Patch
@ledgerhq/evm-tools Patch
@ledgerhq/hw-app-eth Patch
@ledgerhq/test-utils Patch
dummy-wallet-app Patch
@ledgerhq/swift-bridge-hw-app-eth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hedi-edelbloute hedi-edelbloute force-pushed the feat/injective-integ branch 2 times, most recently from c69e2d9 to 9e21513 Compare September 5, 2023 07:09
remove build unsigned method

remove duplicated methods

edit mingasprice

add changeset

remove useless micmac

add unit tests

add icon + pr suggestions

remove unused lib

edit comment

update sortKeys method + unit tests

add nano app version

update gas

add abandonseed

edit min

set fees to integer

test bot

remove estimation from sign op

trial 2

logs

attempt to enable expert mode on init

apply pr remarks

unit tests

add FF

add unit tests

fix lint

fix lint

fix bot hook

fix injective first tx

apply pr remarks

add comm

add injective

integration tests

error management
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking a merge, but a couple possible improvements, could be done in a second step if needed.

libs/ledger-live-common/src/families/cosmos/api/Cosmos.ts Outdated Show resolved Hide resolved
}

if (data.account.sequence) {
response.sequence = parseInt(data.account.sequence);
if (srcAccount.pub_key) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, I don't remember if I asked already: did you see cases where the pub_key field isn't provided?
If it wasn't optional, then we wouldn't need defaultPubKeyType at all, but I assume it is optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub_key is null when account is pristine, we want to use default value else we end up on the bug i resolved last week

libs/ledger-live-common/src/families/cosmos/specs.ts Outdated Show resolved Hide resolved
const generateGenericCosmosTest = (currencyId: string, config?: Partial<AppSpec<Transaction>>) => {
const generateGenericCosmosTest = (
currencyId: string,
isExpertModeRequired: boolean,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking isExpertModeRequired should also belong to AppSpec. There are already a couple custom config params there, and I believe it's better to keep them all centralized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure since it's cosmos specific

@@ -57,6 +57,10 @@ const defaultConfig = {
lcd: "https://full-node.mainnet-1.coreum.dev:1317",
minGasPrice: 0.1,
},
injective: {
lcd: "https://injective-api.polkachu.com",
minGasPrice: 900000000,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any definitive answer here?
What do you think is the better source of truth between chain-registry and kepler?

@github-actions
Copy link

[Bot] Testing with 'Nitrogen' ✅ 2 txs ($0.00) ⏲ 19.9s

✅ 1 specs are successful: injective

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints
  • Spec injective:
    • There are not enough accounts to cover all mutations. Please increase the account target to at least 7 accounts
Details of the 2 mutations

Spec injective (4)

Spec injective found 4 Injective accounts (preload: 473ms). Will use Cosmos 2.34.11 on nanoS 2.1.0
Injective 1 cross: 0.00395326 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
necessary accounts resynced in 0.46ms
▬ Cosmos 2.34.11 on nanoS 2.1.0
→ FROM Injective 1 cross: 0.00395326 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.003953265963534656 INJ spendable. 

max spendable ~0.00386745
★ using mutation 'send max'
→ TO Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
✔️ transaction 
SEND MAX
TO inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x

with fees=0.00008571
STATUS (378ms)
  amount: 0.003867552663534656 INJ
  estimated fees: 0.0000857133 INJ
  total spent: 0.003953265963534656 INJ
errors: 
errors: 
✔️ has been signed! (4.1s) 
✔️ broadcasted! (73ms) optimistic operation: 
  -0.003953265963534656 INJ OUT        96A4F91600A126E8B6A598E035C447D95CA0A9B68889969C9E1E5558894DF630 2023-09-18T12:33
✔️ operation confirmed (1.22ms): 
  -0.003953265963534656 INJ OUT        96A4F91600A126E8B6A598E035C447D95CA0A9B68889969C9E1E5558894DF630 2023-09-18T12:33
✔️ Injective 1 cross: 0.00395326 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.003953265963534656 INJ spendable. 
✔️ destination operation 
  ? -3953265963534656 OUT        96A4F91600A126E8B6A598E035C447D95CA0A9B68889969C9E1E5558894DF630 2023-09-18T12:33

necessary accounts resynced in 0.59ms
▬ Cosmos 2.34.11 on nanoS 2.1.0
→ FROM Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x: (! sum of ops 0 INJ) 0.015698830936465344 INJ spendable. 

max spendable ~0.0156014
★ using mutation 'send some'
→ TO Injective 4: 0 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
✔️ transaction 
SEND  0.010498664576789488 INJ
TO inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm

with fees=0.00011946
STATUS (393ms)
  amount: 0.010498664576789488 INJ
  estimated fees: 0.0001194669 INJ
  total spent: 0.010618131476789488 INJ
errors: 
errors: 
✔️ has been signed! (4.6s) 
✔️ broadcasted! (60ms) optimistic operation: 
  -0.010618131476789488 INJ OUT        6FE23D5F7C07EC66F86E5E2AE67A37AA631A66198DBE1343F66CB26F0007F527 2023-09-18T12:33
✔️ operation confirmed (0.29ms): 
  -0.010618131476789488 INJ OUT        6FE23D5F7C07EC66F86E5E2AE67A37AA631A66198DBE1343F66CB26F0007F527 2023-09-18T12:33
✔️ Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x: (! sum of ops 0 INJ) 0.015698830936465344 INJ spendable. 
✔️ destination operation 
  ? -10618131476789488 OUT        6FE23D5F7C07EC66F86E5E2AE67A37AA631A66198DBE1343F66CB26F0007F527 2023-09-18T12:33


Details of the 4 uncovered mutations

Spec injective (4)

  • delegate new validators: can delegate (2)
  • undelegate: balance is too low (2)
  • redelegate: balance is too low for redelegate (2)
  • claim rewards: balance is too low for claim rewards (2)
Portfolio ($0.00) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
injective (4) 0 ops , 0.019652 INJ ($0.00) inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a
Injective 1 cross: 0.00395326 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Performance ⏲ 19.9s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 473ms 3.3s 13ms 772ms 8.7s 134ms 1.51ms N/A
injective (3) 473ms 3.3s 13ms 772ms 8.7s 134ms 1.51ms N/A

What is the bot and how does it work? Everything is documented here!

@vercel vercel bot temporarily deployed to Preview – ledger-live-docs September 18, 2023 13:11 Inactive
@vercel vercel bot temporarily deployed to Preview – live-common-tools September 18, 2023 13:12 Inactive
@github-actions
Copy link

[Bot] Testing with 'Nitrogen' ✅ 3 txs ($0.00) ⏲ 25.4s

✅ 1 specs are successful: injective

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints
  • Spec injective:
    • There are not enough accounts to cover all mutations. Please increase the account target to at least 7 accounts
Details of the 3 mutations

Spec injective (5)

Spec injective found 5 Injective accounts (preload: 386ms). Will use Cosmos 2.34.12 on nanoS 2.1.0
Injective 1 cross: 0.2 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.00894825 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
necessary accounts resynced in 0.46ms
▬ Cosmos 2.34.12 on nanoS 2.1.0
→ FROM Injective 1 cross: 0.2 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.2 INJ spendable. 

max spendable ~0.199914
★ using mutation 'send some'
→ TO Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
✔️ transaction 
SEND  0.077539773152251081 INJ
TO inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0

with fees=0.00009169
  memo=LedgerLiveBot
STATUS (1033ms)
  amount: 0.077539773152251081 INJ
  estimated fees: 0.000091692 INJ
  total spent: 0.077631465152251081 INJ
errors: 
errors: 
✔️ has been signed! (4.2s) 
✔️ broadcasted! (66ms) optimistic operation: 
  -0.077631465152251081 INJ OUT        5936D2F9F926C737A0128826138406F0C33243B3A065CF1EBE96AC791D9BFDD4 2023-09-18T13:23
✔️ operation confirmed (1.10ms): 
  -0.077631465152251081 INJ OUT        5936D2F9F926C737A0128826138406F0C33243B3A065CF1EBE96AC791D9BFDD4 2023-09-18T13:23
✔️ Injective 1 cross: 0.2 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.2 INJ spendable. 
✔️ destination operation 
  ? -77631465152251081 OUT        5936D2F9F926C737A0128826138406F0C33243B3A065CF1EBE96AC791D9BFDD4 2023-09-18T13:23

necessary accounts resynced in 0.55ms
▬ Cosmos 2.34.12 on nanoS 2.1.0
→ FROM Injective 3: 0.00894825 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x: (! sum of ops 0 INJ) 0.008948252123210512 INJ spendable. 

max spendable ~0.00886244
★ using mutation 'send max'
→ TO Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
✔️ transaction 
SEND MAX
TO inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm

with fees=0.00008571
STATUS (528ms)
  amount: 0.008862538823210512 INJ
  estimated fees: 0.0000857133 INJ
  total spent: 0.008948252123210512 INJ
errors: 
errors: 
✔️ has been signed! (3.8s) 
✔️ broadcasted! (71ms) optimistic operation: 
  -0.008948252123210512 INJ OUT        4C0D02644468D1FA75DF098AF9FBC1E663966362ABBCB20413D4FA8E5317E764 2023-09-18T13:23
✔️ operation confirmed (0.28ms): 
  -0.008948252123210512 INJ OUT        4C0D02644468D1FA75DF098AF9FBC1E663966362ABBCB20413D4FA8E5317E764 2023-09-18T13:23
✔️ Injective 3: 0.00894825 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x: (! sum of ops 0 INJ) 0.008948252123210512 INJ spendable. 
✔️ destination operation 
  ? -8948252123210512 OUT        4C0D02644468D1FA75DF098AF9FBC1E663966362ABBCB20413D4FA8E5317E764 2023-09-18T13:23

necessary accounts resynced in 0.56ms
▬ Cosmos 2.34.12 on nanoS 2.1.0
→ FROM Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm: (! sum of ops 0 INJ) 0.010498664576789488 INJ spendable. 

max spendable ~0.0104013
★ using mutation 'delegate new validators'
✔️ transaction 
DELEGATE  0.000159666519862024 INJ
TO 
  0.000159666519862024 -> injvaloper1vqz7mgm47xhx25xu5g9qagnz48naks6pk6fmg2
with fees=0.00019376
  memo=LedgerLiveBot
STATUS (695ms)
  amount: 0.000159666519862024 INJ
  estimated fees: 0.0001937673 INJ
  total spent: 0.000353433819862024 INJ
errors: 
errors: 
✔️ has been signed! (4.4s) 
✔️ broadcasted! (81ms) optimistic operation: 
  -0.000353433819862024 INJ DELEGATE   F71509C1FCA693ADD87F5DF38D2A67BC7D33A45F4E525966B1DBA3714DED9432 2023-09-18T13:24
    to injvaloper1vqz7mgm47xhx25xu5g9qagnz48naks6pk6fmg2 0.000159666519862024 INJ
✔️ operation confirmed (0.41ms): 
  -0.000353433819862024 INJ DELEGATE   F71509C1FCA693ADD87F5DF38D2A67BC7D33A45F4E525966B1DBA3714DED9432 2023-09-18T13:24
    to injvaloper1vqz7mgm47xhx25xu5g9qagnz48naks6pk6fmg2 0.000159666519862024 INJ
✔️ Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm: (! sum of ops 0 INJ) 0.010498664576789488 INJ spendable. 


Details of the 3 uncovered mutations

Spec injective (3)

  • undelegate: balance is too low (2)
  • redelegate: balance is too low for redelegate (2)
  • claim rewards: balance is too low for claim rewards (2)
Portfolio ($0.00) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
injective (5) 0 ops , 0.219446 INJ ($0.00) inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a
Injective 1 cross: 0.2 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.00894825 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
Performance ⏲ 25.4s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 386ms 3.7s 8ms 2256ms 12.4s 217ms 1.78ms N/A
injective (4) 386ms 3.7s 8ms 2256ms 12.4s 217ms 1.78ms N/A

What is the bot and how does it work? Everything is documented here!

@ghost
Copy link

ghost commented Sep 18, 2023

Another future improvement, from the bots results:

Spec injective:
There are not enough accounts to cover all mutations. Please increase the account target to at least 7 accounts

@github-actions
Copy link

[Bot] Testing with 'Nitrogen' ✅ 3 txs ($0.00) ⏲ 21.3s

✅ 1 specs are successful: injective

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints
  • Spec injective:
    • There are not enough accounts to cover all mutations. Please increase the account target to at least 7 accounts
Details of the 3 mutations

Spec injective (5)

Spec injective found 5 Injective accounts (preload: 405ms). Will use Cosmos 2.34.11 on nanoS 2.1.0
Injective 1 cross: 0.122368 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0.0775397 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0191674 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
necessary accounts resynced in 2.59ms
▬ Cosmos 2.34.11 on nanoS 2.1.0
→ FROM Injective 1 cross: 0.122368 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.122368534847748919 INJ spendable. 

max spendable ~0.122282
★ using mutation 'send some'
→ TO Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
✔️ transaction 
SEND  0.085405310055963564 INJ
TO inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg

with fees=0.000108
STATUS (450ms)
  amount: 0.085405310055963564 INJ
  estimated fees: 0.0001080054 INJ
  total spent: 0.085513315455963564 INJ
errors: 
errors: 
✔️ has been signed! (3.7s) 
✔️ broadcasted! (59ms) optimistic operation: 
  -0.085513315455963564 INJ OUT        EC28A1D42548EA198A9F24965340F2944BDD875C8ECD74F1DEF37A9740EA4A3E 2023-09-18T14:15
✔️ operation confirmed (0.73ms): 
  -0.085513315455963564 INJ OUT        EC28A1D42548EA198A9F24965340F2944BDD875C8ECD74F1DEF37A9740EA4A3E 2023-09-18T14:15
✔️ Injective 1 cross: 0.122368 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a: (! sum of ops 0 INJ) 0.122368534847748919 INJ spendable. 
✔️ destination operation 
  ? -85513315455963564 OUT        EC28A1D42548EA198A9F24965340F2944BDD875C8ECD74F1DEF37A9740EA4A3E 2023-09-18T14:15

necessary accounts resynced in 0.43ms
▬ Cosmos 2.34.11 on nanoS 2.1.0
→ FROM Injective 2: 0.0775397 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0: (! sum of ops 0 INJ) 0.077539773152251081 INJ spendable. 

max spendable ~0.0774539
★ using mutation 'send some'
→ TO Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
✔️ transaction 
SEND  0.050705493505591872 INJ
TO inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg

with fees=0.000108
STATUS (417ms)
  amount: 0.050705493505591872 INJ
  estimated fees: 0.0001080018 INJ
  total spent: 0.050813495305591872 INJ
errors: 
errors: 
✔️ has been signed! (3.7s) 
✔️ broadcasted! (64ms) optimistic operation: 
  -0.050813495305591872 INJ OUT        3D6C507D3E3D18577601F5B425EB5165E6842D00B11EECA1772FB9AF7C1FBA8F 2023-09-18T14:16
✔️ operation confirmed (0.37ms): 
  -0.050813495305591872 INJ OUT        3D6C507D3E3D18577601F5B425EB5165E6842D00B11EECA1772FB9AF7C1FBA8F 2023-09-18T14:16
✔️ Injective 2: 0.0775397 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0: (! sum of ops 0 INJ) 0.077539773152251081 INJ spendable. 
✔️ destination operation 
  ? -50813495305591872 OUT        3D6C507D3E3D18577601F5B425EB5165E6842D00B11EECA1772FB9AF7C1FBA8F 2023-09-18T14:16

necessary accounts resynced in 0.33ms
▬ Cosmos 2.34.11 on nanoS 2.1.0
→ FROM Injective 4: 0.0191674 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm: (! sum of ops 0 INJ) 0.019007769580137976 INJ spendable. 0.000159666519862024 INJ delegated. 
DELEGATIONS
  to injvaloper1vqz7mgm47xhx25xu5g9qagnz48naks6pk6fmg2 0.000159666519862024 INJ  (claimable 0.000159666519862024)

max spendable ~0.0189219
★ using mutation 'delegate new validators'
✔️ transaction 
DELEGATE  0.000097966829195566 INJ
TO 
  0.000097966829195566 -> injvaloper1m4pj2y9qrm77m9gsa8uu7xj6xjyy7du5hg2t2d
with fees=0.00017413
  memo=LedgerLiveBot
STATUS (538ms)
  amount: 0.000097966829195566 INJ
  estimated fees: 0.0001741311 INJ
  total spent: 0.000272097929195566 INJ
errors: 
errors: 
✔️ has been signed! (4s) 
✔️ broadcasted! (64ms) optimistic operation: 
  -0.000272097929195566 INJ DELEGATE   2DF1DEBA1D2D8D46799D405B719E1CB5FD4FF90943F74316A094FF827E19E9AB 2023-09-18T14:16
    to injvaloper1m4pj2y9qrm77m9gsa8uu7xj6xjyy7du5hg2t2d 0.000097966829195566 INJ
✔️ operation confirmed (0.32ms): 
  -0.000272097929195566 INJ DELEGATE   2DF1DEBA1D2D8D46799D405B719E1CB5FD4FF90943F74316A094FF827E19E9AB 2023-09-18T14:16
    to injvaloper1m4pj2y9qrm77m9gsa8uu7xj6xjyy7du5hg2t2d 0.000097966829195566 INJ
✔️ Injective 4: 0.0191674 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm: (! sum of ops 0 INJ) 0.019007769580137976 INJ spendable. 0.000159666519862024 INJ delegated. 
DELEGATIONS
  to injvaloper1vqz7mgm47xhx25xu5g9qagnz48naks6pk6fmg2 0.000159666519862024 INJ  (claimable 0.000159666519862024)


Details of the 4 uncovered mutations

Spec injective (4)

  • send max: balance is too low for send max (2)
  • undelegate: balance is too low (2)
  • redelegate: balance is too low for redelegate (2)
  • claim rewards: balance is too low for claim rewards (2)
Portfolio ($0.00) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
injective (5) 0 ops , 0.218916 INJ ($0.00) inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a
Injective 1 cross: 0.122368 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0.0775397 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0191674 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
Performance ⏲ 21.3s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 405ms 3.3s 4.00ms 1405ms 11.3s 186ms 1.41ms N/A
injective (4) 405ms 3.3s 4.00ms 1405ms 11.3s 186ms 1.41ms N/A

What is the bot and how does it work? Everything is documented here!

@hedi-edelbloute hedi-edelbloute merged commit f527d1b into develop Sep 18, 2023
48 of 51 checks passed
@hedi-edelbloute hedi-edelbloute deleted the feat/injective-integ branch September 18, 2023 14:49
@sentry-io
Copy link

sentry-io bot commented Sep 19, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: currency with id "avalanche_c_chain" not found Di(libs/ledgerjs/packages/cryptoassets/src/curr... View Issue

Did you find this useful? React with a 👍 or 👎

valpinkman added a commit that referenced this pull request Sep 20, 2023
* origin/develop: (91 commits)
  Bugfix: [Stax ESC][LLD] Infinite spinner if user locks Stax at the beginning of ESC (#4705)
  test(lld): update screenshots (windows-latest)  lld, test, screenshot
  test(lld): update screenshots (ubuntu-latest)  lld, test, screenshot
  test(lld): update screenshots (macos-latest)  lld, test, screenshot
  test: fix delegate cosmos teston LLD
  [BUGFIX] Issues on swap (#4741)
  feat: injective integration (#4583)
  [LLM & LLD] Update staking button (#4717)
  Feat/live 9239 update zcash explorer to zcashblockexplorer.com (#4714)
  chore(web-tools): make sure to name it 'web-tools' in package.json
  fix: regen doc
  Feat/llm cex deposit entry points (#4680)
  Feat/save swap history wallet api exchange (#4615)
  chore(deps): update dependency @types/node to v20.6.2
  fix: can find my ledger padding
  fix: renaming on LLM
  feat: send LL version to the manifest-api
  [B2CQA-1972] Detox fix animations flakiness (#4700)
  [BUGFIX] fix wallet-api complete exchange logic (#4699)
  chore(deps): update dependency esbuild to v0.19.3
  ...
hedi-edelbloute added a commit that referenced this pull request Sep 26, 2023
feat: injective integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants