-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: injective integration #4583
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
ce6e6cb
to
fce3fc8
Compare
🦋 Changeset detectedLatest commit: 213a009 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c69e2d9
to
9e21513
Compare
9e21513
to
b781699
Compare
b34dcba
to
33aac1b
Compare
remove build unsigned method remove duplicated methods edit mingasprice add changeset remove useless micmac add unit tests add icon + pr suggestions remove unused lib edit comment update sortKeys method + unit tests add nano app version update gas add abandonseed edit min set fees to integer test bot remove estimation from sign op trial 2 logs attempt to enable expert mode on init apply pr remarks unit tests add FF add unit tests fix lint fix lint fix bot hook fix injective first tx apply pr remarks add comm add injective integration tests error management
33aac1b
to
837ef51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking a merge, but a couple possible improvements, could be done in a second step if needed.
} | ||
|
||
if (data.account.sequence) { | ||
response.sequence = parseInt(data.account.sequence); | ||
if (srcAccount.pub_key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, I don't remember if I asked already: did you see cases where the pub_key
field isn't provided?
If it wasn't optional, then we wouldn't need defaultPubKeyType
at all, but I assume it is optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub_key is null when account is pristine, we want to use default value else we end up on the bug i resolved last week
const generateGenericCosmosTest = (currencyId: string, config?: Partial<AppSpec<Transaction>>) => { | ||
const generateGenericCosmosTest = ( | ||
currencyId: string, | ||
isExpertModeRequired: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking isExpertModeRequired
should also belong to AppSpec
. There are already a couple custom config params there, and I believe it's better to keep them all centralized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure since it's cosmos specific
@@ -57,6 +57,10 @@ const defaultConfig = { | |||
lcd: "https://full-node.mainnet-1.coreum.dev:1317", | |||
minGasPrice: 0.1, | |||
}, | |||
injective: { | |||
lcd: "https://injective-api.polkachu.com", | |||
minGasPrice: 900000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any definitive answer here?
What do you think is the better source of truth between chain-registry and kepler?
[Bot] Testing with 'Nitrogen' ✅ 2 txs ($0.00) ⏲ 19.9s
|
Spec (accounts) | State | Remaining Runs (est) | funds? |
---|---|---|---|
injective (4) | 0 ops , 0.019652 INJ ($0.00) | ❌ | inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a |
Injective 1 cross: 0.00395326 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.0156988 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Performance ⏲ 19.9s
Time spent for each spec: (total across mutations)
Spec (accounts) | preload | scan | re-sync | tx status | sign op | broadcast | test | destination test |
---|---|---|---|---|---|---|---|---|
TOTAL | 473ms | 3.3s | 13ms | 772ms | 8.7s | 134ms | 1.51ms | N/A |
injective (3) | 473ms | 3.3s | 13ms | 772ms | 8.7s | 134ms | 1.51ms | N/A |
What is the bot and how does it work? Everything is documented here!
00a2d85
to
213a009
Compare
[Bot] Testing with 'Nitrogen' ✅ 3 txs ($0.00) ⏲ 25.4s
|
Spec (accounts) | State | Remaining Runs (est) | funds? |
---|---|---|---|
injective (5) | 0 ops , 0.219446 INJ ($0.00) | ❌ | inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a |
Injective 1 cross: 0.2 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0.00894825 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0104986 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
Performance ⏲ 25.4s
Time spent for each spec: (total across mutations)
Spec (accounts) | preload | scan | re-sync | tx status | sign op | broadcast | test | destination test |
---|---|---|---|---|---|---|---|---|
TOTAL | 386ms | 3.7s | 8ms | 2256ms | 12.4s | 217ms | 1.78ms | N/A |
injective (4) | 386ms | 3.7s | 8ms | 2256ms | 12.4s | 217ms | 1.78ms | N/A |
What is the bot and how does it work? Everything is documented here!
Another future improvement, from the bots results:
|
[Bot] Testing with 'Nitrogen' ✅ 3 txs ($0.00) ⏲ 21.3s
|
Spec (accounts) | State | Remaining Runs (est) | funds? |
---|---|---|---|
injective (5) | 0 ops , 0.218916 INJ ($0.00) | ❌ | inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a |
Injective 1 cross: 0.122368 INJ (0ops) (inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a on 44'/60'/0'/0/0) #0 js:2:injective:inj1vzjwweta3hegt99vfgrvmcq7rr5532yjsgxd4a:
Injective 2: 0.0775397 INJ (0ops) (inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0 on 44'/60'/1'/0/0) #1 js:2:injective:inj1jz75s9zwpzmxfy9u4xn4d00f7qz0z7zhzmzvf0:
Injective 3: 0 INJ (0ops) (inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x on 44'/60'/2'/0/0) #2 js:2:injective:inj1km5tqdc6zhx6muwcak3577y8pf0x3ze9g6kh8x:
Injective 4: 0.0191674 INJ (0ops) (inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm on 44'/60'/3'/0/0) #3 js:2:injective:inj1usz0z2ryg3vutg8kltrgyjk63728nry0u8u7jm:
Injective 5: 0 INJ (0ops) (inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg on 44'/60'/4'/0/0) #4 js:2:injective:inj1wu9txhtv90z0us0kz6ly0d3xaaazsy8fum9mhg:
Performance ⏲ 21.3s
Time spent for each spec: (total across mutations)
Spec (accounts) | preload | scan | re-sync | tx status | sign op | broadcast | test | destination test |
---|---|---|---|---|---|---|---|---|
TOTAL | 405ms | 3.3s | 4.00ms | 1405ms | 11.3s | 186ms | 1.41ms | N/A |
injective (4) | 405ms | 3.3s | 4.00ms | 1405ms | 11.3s | 186ms | 1.41ms | N/A |
What is the bot and how does it work? Everything is documented here!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
* origin/develop: (91 commits) Bugfix: [Stax ESC][LLD] Infinite spinner if user locks Stax at the beginning of ESC (#4705) test(lld): update screenshots (windows-latest) lld, test, screenshot test(lld): update screenshots (ubuntu-latest) lld, test, screenshot test(lld): update screenshots (macos-latest) lld, test, screenshot test: fix delegate cosmos teston LLD [BUGFIX] Issues on swap (#4741) feat: injective integration (#4583) [LLM & LLD] Update staking button (#4717) Feat/live 9239 update zcash explorer to zcashblockexplorer.com (#4714) chore(web-tools): make sure to name it 'web-tools' in package.json fix: regen doc Feat/llm cex deposit entry points (#4680) Feat/save swap history wallet api exchange (#4615) chore(deps): update dependency @types/node to v20.6.2 fix: can find my ledger padding fix: renaming on LLM feat: send LL version to the manifest-api [B2CQA-1972] Detox fix animations flakiness (#4700) [BUGFIX] fix wallet-api complete exchange logic (#4699) chore(deps): update dependency esbuild to v0.19.3 ...
feat: injective integration
📝 Description
What this PR does :
❓ Context
LLC,LLD,LLM
https://ledgerhq.atlassian.net/browse/LIVE-8106
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.