Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errors in drawer #7776

Merged
merged 1 commit into from
Sep 9, 2024

fix: remove errors in drawer

6c80091
Select commit
Loading
Failed to load commit list.
Merged

fix: remove errors in drawer #7776

fix: remove errors in drawer
6c80091
Select commit
Loading
Failed to load commit list.
live-github-bot / @Desktop β€’ Build App succeeded Sep 9, 2024 in 8m 45s

βœ… Success

Build the Ledger Live Desktop application on all platforms and attach the binaries to the workflow run.

πŸ”— Workflow run
🐧 Linux πŸͺŸ Windows 🍏 macOS
βœ… (success) βœ… (success) βœ… (success)

βš™οΈ Summary

Details

πŸ’‘ Basics Tips

To share some piece of advice and help the community, please do not hesitate to edit this file and submit a pull request. Thank you! πŸ™

If you're troubleshooting a build failure, here are a few tips to keep in mind.

Note: you should always navigate to the workflow run page linked above to get additional information about the build failure.

⚠️ Read the logs ⚠️

Start by carefully reading the logs. In most cases (99% of the time), this will be enough to understand the cause of the failure.

Determine if the failure is os-specific

LLD is built on Linux, macOS, and Windows, and some errors may only occur on a single platform.

Identify the specific step where the error occurred

The LLD build process consists of the following actions that are performed sequentially (in a nutshell):

  • For each os (in parallel):
    • Checkout the repository. ℹ️ For pull requests, it does a checkout of the branch targeted by the pull request, merges the pull request branch into it and then runs the workflow from that merge commit. It does NOT run at the HEAD commit of the pull request branch. So if you have different results locally make sure to checkout, fetch and pull the target branch and rebase your branch onto it.
    • Install the system dependencies
    • Install the javascript dependencies
    • Build the native node.js addons
    • Build all the dependencies required by LLD and belonging to the ledger-live repository
    • And finally, build the application

Look for for the source of the error in the logs.

Use the keyboard shortcut Cmd + F on macOS or Ctrl + F on Windows and Linux to search for the relevant error message.

The error could be unrelated to the LLD codebase, but rather related to a dependency like live-common or ledgerjs.

Check other runs of the same workflow

Check other runs of the same workflow. If other branches are experiencing the same issue, it's likely that the error is not specific to your code.

Review the workflow code.

The workflow YAML file provides information about the commands that are run on the continuous integration (CI) environment.

You should be able to reproduce locally by simply running the commands in the same order.

Infrastucture issues

Consider the possibility of infrastructure issues. If the error appears to be related to a slow network or a physical machine, it's possible that the problem is not related to the code. In this case, wait a bit and restart the job, or contact the infrastructure team if the problem persists.