Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-11671] Remove feature flag "deviceSupportEuropa" (for Ledger Flex) #7780

Merged
merged 3 commits into from
Sep 11, 2024
Merged

[LIVE-11671] Remove feature flag "deviceSupportEuropa" (for Ledger Flex) #7780

merged 3 commits into from
Sep 11, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Sep 9, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Ledger Flex is now always always in "setup new device" selection screens (without the need for a feature flag)
    • When opening an NFT and using it as a lockscreen, there always will be the choice between Flex & Stax in the preview screen (without the need for a feature flag)
    • The deviceSupportEuropa feature flag & the europa feature flag group are no longer in the Feature Flag debug settings

📝 Description

Removal of the "deviceSupportEuropa" which was meant to control the visibility of Ledger Flex in Ledger Live. The device has been released so the feature flag was activated and is not required anymore.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ofreyssinet-ledger ofreyssinet-ledger requested review from a team as code owners September 9, 2024 15:03
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 1:18pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 1:18pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 1:18pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 1:18pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 1:18pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Sep 9, 2024
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/live-11671-remove-flag-europa branch from 6cfd975 to 882e7ad Compare September 9, 2024 15:28
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/live-11671-remove-flag-europa branch from 882e7ad to c668987 Compare September 9, 2024 15:33
@ofreyssinet-ledger
Copy link
Contributor Author

ofreyssinet-ledger commented Sep 9, 2024 •
edited by live-github-bot bot
Loading

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Sep 10, 2024
mcayuelas-ledger
mcayuelas-ledger previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Hub Scope

@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/live-11671-remove-flag-europa branch from b85a54e to 14c47f6 Compare September 10, 2024 09:59
@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Sep 10, 2024
@ofreyssinet-ledger
Copy link
Contributor Author

ofreyssinet-ledger commented Sep 10, 2024 •
edited by live-github-bot bot
Loading

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Sep 10, 2024
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/live-11671-remove-flag-europa branch from 6d52b4d to 5984f81 Compare September 10, 2024 13:06
@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Sep 10, 2024
@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Sep 10, 2024
@ofreyssinet-ledger ofreyssinet-ledger merged commit 9ae8724 into develop Sep 11, 2024
58 of 59 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the support/live-11671-remove-flag-europa branch September 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@jiyuzhuang jiyuzhuang jiyuzhuang approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@ofreyssinet-ledger ofreyssinet-ledger

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM screenshots Screenshots have been updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofreyssinet-ledger @jiyuzhuang @ypolishchuk-ledger @bharamboure-ledger @mcayuelas-ledger