✨feat(lld): add simplehash calls for ordis #7783

LucasWerey · 2024-09-10T08:14:01Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- BTC account
- live-nft-react
- inscriptions/rare Sats tables

📝 Description

This is the third PR of LIVE-12479
We can use the same API to fetch inscriptions and rare sats. For this we use utxo addresses from Account as it's a BitcoinAccount. After some manipulations we can separate rare sats and inscriptions to fill the two tables.

Inside live-nft-react we only remove all the common sats from the object and separate inscriptions and rare sats.
There is a restructuration inside Collectibles/Hooks of the object.

Since we use tanstack I've added an error message when the API respond with an error. It can be useful particularly because it's an external API

A tooltip is added when hovering specific rare sat icon in rare sats table and inscription table. Some of the rare sats don't have description.

Important

Some inscriptions have a canvas as media. In LLD / LLM we are currently not able to display them. A solution would be to use an iFrame but this can represents some risk since the API is from a partner. A solution would be to do as it has been done during hackathon by using magicEden endpoint but not sure we have the right 👀
it has been decided to prioritise safety so we will display fallback image for the moment
also utxo_size is removed of the table since no other platforms displays it and product is not sure about the utility of this information

Screen.Recording.2024-09-12.at.15.38.38.mov

❓ Context

JIRA or GitHub link: LIVE-12479

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-09-10T08:14:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 3:58pm

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Sep 19, 2024 3:58pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Sep 19, 2024 3:58pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Sep 19, 2024 3:58pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Sep 19, 2024 3:58pm

mcayuelas-ledger · 2024-09-16T08:20:50Z

libs/live-nft-react/src/hooks/useFetchOrdinals.ts

+  useEffect(() => {
+    if (queryResult.hasNextPage && !queryResult.isFetchingNextPage) {
+      queryResult.fetchNextPage();
+    }
+  }, [queryResult, queryResult.hasNextPage, queryResult.isFetchingNextPage]);


why do you need useEffect ?

You try to fetch every pages without scrolling?

The issue is that rare sats table doesn't load progressively but should displays everything once. And because I use the same call for Inscriptions and RareSats I need to fetch all pages but I agree not the best

You are right, I just wanted to know if this is expected to fetch "all pages" :)

but looks good and with useInfiniteQuery there is not a lot of solution to di it ^^

https://tanstack.com/query/latest/docs/framework/react/reference/useInfiniteQuery

maybe you can do something with getNextPageParam & allPages

Not sure I can do anything using allPages

mcayuelas-ledger · 2024-09-16T09:31:03Z

apps/ledger-live-desktop/src/renderer/screens/account/index.tsx

@@ -220,7 +221,7 @@ const AccountPage = ({
            )
          ) : null}
          {isOrdinalsEnabled && account.type === "Account" && account.currency.id === "bitcoin" ? (
-            <OrdinalsAccount account={account} />
+            <OrdinalsAccount account={account as BitcoinAccount} />


Because I need to have the bitcoinRessources that are only inside BitcoinAccount and I thought it would be cleaner to do it this way to avoid ts error. I can add a utils to check if it's a btc account by checking if the account has bitcoinResources

Changed for two type guards => one that checks if it's a fork of btc and one to check if that fork is a BTC account or a fork

apps/ledger-live-desktop/src/newArch/features/Collectibles/Ordinals/components/Loader.tsx

...er-live-desktop/src/newArch/features/Collectibles/Ordinals/components/Inscriptions/index.tsx

mcayuelas-ledger · 2024-09-19T13:53:25Z

apps/ledger-live-desktop/src/renderer/screens/account/index.tsx

+  function isBitcoinAccount(account: BitcoinAccount): boolean {
+    return account.currency.id === "bitcoin";
+  }


could be moved outside in an helper ?

also you can just do account: Account

Added to common lib so I will be able to use it on LLM too

apps/ledger-live-desktop/src/newArch/features/Collectibles/Ordinals/screens/Account/index.tsx

✨feat(ui): add simplehash calls for ordis

github-actions bot assigned LucasWerey Sep 10, 2024

live-github-bot bot added the desktop Has changes in LLD label Sep 10, 2024

vercel bot deployed to Preview – web-tools September 10, 2024 08:17 View deployment

LucasWerey force-pushed the feat/LIVE-12467-c branch from 6d95b40 to f1fe8c0 Compare September 10, 2024 13:32

vercel bot had a problem deploying to Preview – web-tools September 10, 2024 13:33 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from f1fe8c0 to 700691a Compare September 10, 2024 13:39

vercel bot had a problem deploying to Preview – web-tools September 10, 2024 13:40 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 700691a to 2d0c38b Compare September 10, 2024 13:55

vercel bot had a problem deploying to Preview – web-tools September 10, 2024 13:57 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 2d0c38b to d6342b9 Compare September 10, 2024 14:19

live-github-bot bot added the translations Translation files have been touched label Sep 10, 2024

vercel bot had a problem deploying to Preview – web-tools September 10, 2024 14:22 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from d6342b9 to ccf1446 Compare September 10, 2024 14:32

vercel bot had a problem deploying to Preview – web-tools September 10, 2024 14:33 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from ccf1446 to 1bb85d6 Compare September 11, 2024 09:17

vercel bot deployed to Preview – web-tools September 11, 2024 09:21 View deployment

LucasWerey force-pushed the feat/LIVE-12467-c branch from 1bb85d6 to 105f573 Compare September 12, 2024 08:02

vercel bot deployed to Preview – web-tools September 12, 2024 08:06 View deployment

LucasWerey force-pushed the feat/LIVE-12467-c branch 2 times, most recently from 9b9d88a to 9cd4895 Compare September 12, 2024 13:08

vercel bot deployed to Preview – web-tools September 12, 2024 13:13 View deployment

LucasWerey force-pushed the feat/LIVE-12467-c branch from 9cd4895 to 1758aac Compare September 12, 2024 13:41

vercel bot had a problem deploying to Preview – web-tools September 12, 2024 13:43 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 1758aac to 5621f80 Compare September 12, 2024 17:02

vercel bot had a problem deploying to Preview – web-tools September 12, 2024 17:04 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 5621f80 to 13a428c Compare September 12, 2024 17:04

vercel bot had a problem deploying to Preview – web-tools September 12, 2024 17:06 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 13a428c to d3d6f9d Compare September 12, 2024 17:06

vercel bot deployed to Preview – web-tools September 12, 2024 17:10 View deployment

vercel bot had a problem deploying to Preview – web-tools September 13, 2024 14:41 Failure

LucasWerey marked this pull request as ready for review September 13, 2024 14:45

LucasWerey requested review from a team as code owners September 13, 2024 14:45

LucasWerey force-pushed the feat/LIVE-12467-c branch from fa1b52f to 0b8b700 Compare September 13, 2024 14:53

LucasWerey changed the title ~~✨feat(ui): add simplehash calls for ordis~~ ✨feat(lld): add simplehash calls for ordis Sep 13, 2024

vercel bot had a problem deploying to Preview – web-tools September 13, 2024 15:01 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 0b8b700 to c8493b4 Compare September 13, 2024 16:29

vercel bot had a problem deploying to Preview – web-tools September 13, 2024 16:31 Failure

mcayuelas-ledger reviewed Sep 16, 2024

View reviewed changes

LucasWerey force-pushed the feat/LIVE-12467-c branch from c8493b4 to ebbb163 Compare September 19, 2024 12:37

vercel bot deployed to Preview – web-tools September 19, 2024 12:44 View deployment

LucasWerey force-pushed the feat/LIVE-12467-c branch from ebbb163 to fee6331 Compare September 19, 2024 13:12

vercel bot had a problem deploying to Preview – web-tools September 19, 2024 13:14 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from fee6331 to 62f36bf Compare September 19, 2024 13:36

vercel bot had a problem deploying to Preview – web-tools September 19, 2024 13:37 Failure

LucasWerey force-pushed the feat/LIVE-12467-c branch from 62f36bf to a1436f9 Compare September 19, 2024 13:37

vercel bot had a problem deploying to Preview – web-tools September 19, 2024 13:40 Failure

mcayuelas-ledger reviewed Sep 19, 2024

View reviewed changes

LucasWerey force-pushed the feat/LIVE-12467-c branch from a1436f9 to caf32a6 Compare September 19, 2024 14:18

live-github-bot bot added the common Has changes in live-common label Sep 19, 2024

vercel bot deployed to Preview – web-tools September 19, 2024 14:22 View deployment

✨feat(ui): add simplehash calls for ordis

b2198d7

LucasWerey force-pushed the feat/LIVE-12467-c branch from caf32a6 to b2198d7 Compare September 19, 2024 15:54

vercel bot deployed to Preview – web-tools September 19, 2024 15:58 View deployment

mcayuelas-ledger approved these changes Sep 20, 2024

View reviewed changes

VicAlbr approved these changes Sep 20, 2024

View reviewed changes

LucasWerey merged commit e4b6647 into develop Sep 20, 2024
54 of 56 checks passed

LucasWerey deleted the feat/LIVE-12467-c branch September 20, 2024 12:30

mcayuelas-ledger pushed a commit that referenced this pull request Sep 20, 2024

✨feat(lld): add simplehash calls for ordis (#7783)

ab4b305

✨feat(ui): add simplehash calls for ordis

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨feat(lld): add simplehash calls for ordis #7783

✨feat(lld): add simplehash calls for ordis #7783

LucasWerey commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

mcayuelas-ledger Sep 16, 2024

LucasWerey Sep 16, 2024 •

edited

Loading

mcayuelas-ledger Sep 18, 2024

mcayuelas-ledger Sep 18, 2024

LucasWerey Sep 20, 2024

mcayuelas-ledger Sep 16, 2024

LucasWerey Sep 16, 2024

LucasWerey Sep 19, 2024

mcayuelas-ledger Sep 19, 2024

LucasWerey Sep 19, 2024

✨feat(lld): add simplehash calls for ordis #7783

✨feat(lld): add simplehash calls for ordis #7783

Conversation

LucasWerey commented Sep 10, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

LucasWerey Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LucasWerey commented Sep 10, 2024 •

edited

Loading

vercel bot commented Sep 10, 2024 •

edited

Loading

LucasWerey Sep 16, 2024 •

edited

Loading