Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llm): 🏚️ run tests at e2e/specs/*.spec.ts #7928

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Sep 26, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Tests files at e2e/specs/*.spec.ts are no longer run. It comes from a change in #7789 which looks accidental to me. Here's the change in the glob pattern (from https://www.digitalocean.com/community/tools/glob)

Before After
image image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested review from a team as code owners September 26, 2024 15:15
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 26, 2024 3:15pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:15pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:15pm
react-ui-storybook ⬜️ Ignored (Inspect) Sep 26, 2024 3:15pm
web-tools ⬜️ Ignored (Inspect) Sep 26, 2024 3:15pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 26, 2024
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix !

@thesan thesan merged commit d304a32 into develop Sep 27, 2024
44 checks passed
@thesan thesan deleted the chore/llm-forgotten-e2e-tests branch September 27, 2024 14:05
valpinkman added a commit that referenced this pull request Sep 27, 2024
* develop: (42 commits)
  chore(llm): 🏚️ run tests at `e2e/specs/*.spec.ts` (#7928)
  feat: use cal as sell provider source of true (#7886)
  fix: external workflow call
  fix: checkout external contributions
  fix: external contribution concurrency
  test: get logs for failed tests
  fix: external contribution conditions to run
  ✨(lld): add details drawer for inscriptions (#7908)
  chore(lld): πŸ‘Œ always skip the analytics prompt in e2e tests (#7910)
  ✨(lld): add protect box inside discovery drawer (#7924)
  feat: 🌐 localize storyly (#7923)
  chore(llm): πŸ‘Œ always skip the analytics prompt in e2e tests (#7890)
  fix: increase FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT for nightly build
  test: πŸ› creating new addAccount function for mocked tests
  test: πŸ§ͺ fix add account (bitcoin)
  fix(wallet-api): open any deep-link from the webview on LLM Needed for wallet-connect-live-app deep-link back to mobile dApps
  fix: remove rewards from near staking
  fix(LLM): allow wallet-connect live-app to open a deep-link at any time [LIVE-13641] Refactor by sharing a single constant for wallet-connect live-app manifest id
  chore: bump storyly version and adapt new api spec (#7896)
  πŸ›(lld): fix inte test for nfts (#7914)
  ...
nicolas-meilan pushed a commit to nicolas-meilan/ledger-live that referenced this pull request Sep 27, 2024
* chore(llm): run tests at `e2e/specs/*.spec.ts`

* chore: update change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants