Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move crypto org into cosmos coin module #8374

Merged
merged 25 commits into from
Dec 20, 2024
Merged

fix: move crypto org into cosmos coin module #8374

merged 25 commits into from
Dec 20, 2024

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Nov 15, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Move cryto_org into cosmos coin module.
Change stakingDocUrl

Screen.Recording.2024-11-19.at.16.34.12.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@qperrot qperrot requested review from a team as code owners November 15, 2024 10:20
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:00pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:00pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:00pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:00pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Nov 15, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Nov 15, 2024 •
edited
Loading

Desktop Bundle Checks

Comparing 2daac3f against eccd715.

🚀 renderer bundle size decreased (38.5mb -> 36.7mb). Thanks ❤️
🚀 bip39 library is no longer duplicated in renderer
🚀 web3-utils library is no longer duplicated in renderer
🚀 moment library is no longer duplicated in renderer
🚀 @cosmjs/proto-signing library is no longer duplicated in renderer
🚀 @cosmjs/amino library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 2daac3f against eccd715.

🚀 main.ios.jsbundle bundle size decreased (62.2mb -> 60.2mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (62.2mb -> 60.2mb). Thanks ❤️

@qperrot qperrot marked this pull request as draft November 15, 2024 11:07
@qperrot qperrot marked this pull request as ready for review November 19, 2024 09:24
Canestin
Canestin requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Canestin Canestin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual tests on Ledger Live

  1. Add Account Modal:

    • Letters not displaying during search
    • "Cronos POS Chain" missing

    image

apps/ledger-live-desktop/src/newArch/features/MemoTag/constants.ts Outdated Show resolved Hide resolved
@qperrot qperrot force-pushed the support/cosmos-crypto-org branch 2 times, most recently from 8a28ce8 to cb43a01 Compare November 19, 2024 15:27
Canestin
Canestin previously approved these changes Nov 19, 2024
View reviewed changes
@qperrot qperrot requested a review from Wozacosta November 20, 2024 15:06
Wozacosta
Wozacosta previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj 🚀

@qperrot qperrot dismissed stale reviews from Wozacosta and Canestin via feb8497 November 25, 2024 13:13
@qperrot qperrot force-pushed the support/cosmos-crypto-org branch from cb43a01 to feb8497 Compare November 25, 2024 13:13
qperrot added 24 commits December 19, 2024 13:39
@qperrot
fix: removed export from crypto_org familie
2b80cf5
@qperrot
fix: remove unused package
d55a616
@qperrot
fix: update cosmos snapshot
15bbd55
@qperrot
fix: test crypto_org
d75cd17
@qperrot
fix: test sortByMarketcap
299e266
@qperrot
chore: add changeset
d2d1340
@qperrot
fix: changeset patch to minor
50b00c7
@qperrot
fix: remove old changeset
929e30f
@qperrot
fix: change validator and delegation, need to fix old account already…
3a76266 
… delegate
@qperrot
fix: Cosmos chains stakingDocUrl
c6223e6
@qperrot
fix: front end if no cosmosResources
91ef955
@qperrot
fix: update snapshot cosmos
41fe441
@qperrot
fix: bot nitrogen
5e9aec7
@qperrot
fix: cosmos snapshot
541647c
@qperrot
fix: rebase and modif timeout for crypto org
0117ddd
@qperrot
fix: uniported
13d20fb
@qperrot
fix: pnpm and bridge.js
436bbf5
@qperrot
fix: remove crypto_org feature flag
a1d6ad0
@qperrot
fix: increase specs timeout
a2b7031
@qperrot
fix: snapshots updated
c4f0821
@qperrot
fix: action device
5c81d7b
@qperrot
fix: remove @crypto-org-chain/chain-jslib
6de1541
@qperrot
fix: cosmos snapshot
1347fb8
@qperrot
fix: rebase and pnpm.lock
e59e766
@qperrot qperrot force-pushed the support/cosmos-crypto-org branch from 53b00a9 to e59e766 Compare December 19, 2024 13:00
@qperrot qperrot requested a review from themooneer December 19, 2024 13:04
themooneer
themooneer approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification tests LLD:

  • App startup ✅
  • Send Flow with cosmos ✅

Verification tests LLM:

  • App startup ✅

Verified bundle size 36.7mb ✅

LGTM

@qperrot qperrot merged commit bb70f5c into develop Dec 20, 2024
54 of 55 checks passed
@qperrot qperrot deleted the support/cosmos-crypto-org branch December 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@Wozacosta Wozacosta Wozacosta approved these changes

@Canestin Canestin Canestin left review comments

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@qperrot qperrot

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qperrot @Wozacosta @themooneer @ypolishchuk-ledger @Canestin