Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feature_llm_market_coin_quick_actions FF removed #8565

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: feature_llm_market_coin_quick_actions FF removed #8565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/red-buttons-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ledgerhq/types-live": minor
"live-mobile": minor
"@ledgerhq/live-common": minor
---

Remove feature_llm_market_coin_quick_actions FF
39 changes: 0 additions & 39 deletions apps/ledger-live-mobile/src/components/FabActions/actionsList/market/index.tsx
View file
Open in desktop

This file was deleted.

24 changes: 1 addition & 23 deletions apps/ledger-live-mobile/src/newArch/features/Market/screens/MarketDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { memo, useMemo, useState } from "react";
import { useTheme } from "styled-components/native";
import FeatureToggle from "@ledgerhq/live-common/featureFlags/FeatureToggle";
import { Flex, ScrollContainerHeader, Text } from "@ledgerhq/native-ui";
import { FlatList, Image, RefreshControl } from "react-native";
import { useTranslation } from "react-i18next";
Expand All @@ -17,7 +16,6 @@ import Button from "~/components/wrappedUi/Button";
import MarketGraph from "./components/MarketGraph";
import { ScreenName } from "~/const";
import { withDiscreetMode } from "~/context/DiscreetModeContext";
import { FabMarketActions } from "~/components/FabActions/actionsList/market";
import { MarketQuickActions } from "~/components/MarketQuickActions";
import BackButton from "./components/BackButton";
import { Item } from "~/components/Graph/types";
Expand Down Expand Up @@ -49,7 +47,6 @@ function View({
loading,
loadingChart,
refresh,
defaultAccount,
toggleStar,
currency,
dataChart,
Expand Down Expand Up @@ -138,21 +135,6 @@ function View({
)}
</Flex>
</Flex>

{internalCurrency ? (
<FeatureToggle
featureId="llmMarketQuickActions"
fallback={
<Flex mb={6}>
<FabMarketActions
defaultAccount={defaultAccount}
currency={internalCurrency}
accounts={accounts}
/>
</Flex>
}
/>
) : null}
</>
}
refreshControl={
Expand All @@ -173,11 +155,7 @@ function View({
currency={internalCurrency}
/>

{internalCurrency && (
<FeatureToggle featureId="llmMarketQuickActions">
<MarketQuickActions currency={internalCurrency} accounts={accounts} />
</FeatureToggle>
)}
{internalCurrency && <MarketQuickActions currency={internalCurrency} accounts={accounts} />}

{accounts?.length > 0 ? (
<Flex mx={6} mt={8}>
Expand Down
1 change: 0 additions & 1 deletion libs/ledger-live-common/src/featureFlags/defaultFeatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ export const DEFAULT_FEATURES: Features = {
lldnewArchOrdinals: DEFAULT_FEATURE,
enableAppsBackup: DEFAULT_FEATURE,
web3hub: DEFAULT_FEATURE,
llmMarketQuickActions: DEFAULT_FEATURE,
spamFilteringTx: DEFAULT_FEATURE,
llmMemoTag: DEFAULT_FEATURE,
lldMemoTag: DEFAULT_FEATURE,
Expand Down
1 change: 0 additions & 1 deletion libs/ledgerjs/packages/types-live/src/feature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ export type Features = CurrencyFeatures & {
lldnewArchOrdinals: DefaultFeature;
enableAppsBackup: Feature_EnableAppsBackup;
web3hub: Feature_web3hub;
llmMarketQuickActions: DefaultFeature;
spamFilteringTx: Feature_SpamFilteringTx;
llmMemoTag: Feature_MemoTag;
lldMemoTag: Feature_MemoTag;
Expand Down
Loading