Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiversx Rebranding #8630

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

popenta
Copy link
Contributor

@popenta popenta commented Dec 6, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Renamed packages and as much code as possible from Elrond to MultiversX.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@popenta popenta requested review from a team as code owners December 6, 2024 12:56
@popenta popenta requested review from a team as code owners December 6, 2024 12:56
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 9:16am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 9:16am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 9:16am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 9:16am

Copy link

vercel bot commented Dec 6, 2024

@popenta is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli fork Pull request base branch comes from a fork. labels Dec 6, 2024
@ledger-wiz-cspm-secret-detection

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 3 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 3 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changeset, you can generate it with pnpm changelog and only setting changes as patches

@popenta
Copy link
Contributor Author

popenta commented Dec 18, 2024

Missing a changeset, you can generate it with pnpm changelog and only setting changes as patches

Generated it, I hope it's alright.

@Wozacosta
Copy link
Contributor

Made a PR based on yours that attempts to fix a few of the issues you had on the CI, still more checks to be done but at least most errors are gone,

#8757

Copy link

github-actions bot commented Jan 9, 2025

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM Stale tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants